This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Fix class structure for meeting notification feature extensibility #6579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2779c8c to
6ab06ca
Compare
6ab06ca to
605d6bd
Compare
singhk97
reviewed
Jan 24, 2023
singhk97
reviewed
Jan 24, 2023
libraries/Microsoft.Bot.Schema/Teams/NotificationRecipientFailureInfo.cs
Outdated
Show resolved
Hide resolved
YunnyChung
reviewed
Jan 24, 2023
libraries/Microsoft.Bot.Schema/Teams/BotMeetingNotificationChannelData.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Schema/Teams/BotMeetingNotificationChannelData.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Schema/Teams/TargetedMeetingNotificationValue.cs
Outdated
Show resolved
Hide resolved
YunnyChung
reviewed
Jan 24, 2023
YunnyChung
left a comment
There was a problem hiding this comment.
Additional comment for my own learning :)
libraries/Microsoft.Bot.Connector/Teams/TeamsOperationsExtensions.cs
Outdated
Show resolved
Hide resolved
66bbed4 to
c7e4058
Compare
…s pass, manual tests pass
c7e4058 to
e9fc060
Compare
vule-msft
suggested changes
Jan 27, 2023
libraries/Microsoft.Bot.Schema/Teams/BotMeetingNotificationChannelData.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Schema/Teams/MeetingNotificationResponse.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Schema/Teams/MeetingNotificationResponse.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Schema/Teams/NotificationRecipientFailureInfo.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Schema/Teams/TargetedMeetingNotification.cs
Outdated
Show resolved
Hide resolved
YunnyChung
reviewed
Jan 27, 2023
libraries/Microsoft.Bot.Schema/Teams/BotMeetingNotificationChannelData.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Schema/Teams/NotificationRecipientFailureInfo.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Schema/Teams/TargetedMeetingNotificationValue.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Schema/Teams/TargetedMeetingNotification.cs
Outdated
Show resolved
Hide resolved
457649f to
4ddab23
Compare
YunnyChung
approved these changes
Jan 30, 2023
7999537 to
8f29579
Compare
singhk97
approved these changes
Jan 31, 2023
8f29579 to
2e4b4ae
Compare
Contributor
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll |
tracyboehrer
approved these changes
Feb 7, 2023
tracyboehrer
pushed a commit
that referenced
this pull request
Feb 13, 2023
…6579) * draft PR check remote build * Fix class model, update reference, unit test, and comments. Unit tests pass, manual tests pass * Addressing comments --------- Co-authored-by: Ying Du <yingdu@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6580
Description
This PR fixes the extensibility issue for the Teams bot meeting notification feature by updating on model classes.
Specific Changes
Update classes to support different types of meeting notification, surface type, and content type.
Update reference and unit tests.
Testing
Update and pass unit tests.
Pass manual testing via personal test bot.