This repository was archived by the owner on Jan 5, 2026. It is now read-only.
SetSpeakMiddleware - remove lang argument #5404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracyboehrer
approved these changes
Apr 1, 2021
tracyboehrer
pushed a commit
that referenced
this pull request
Apr 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5403
Description
Removes the lang argument from the SetSpeakMiddleware implementation to align with the current implementation in the Composer runtime (https://github.com/microsoft/BotFramework-Composer/blob/ea04f990e0b675b8ce35f315d5a6c1d6264ae525/runtime/dotnet/core/SetSpeakMiddleware.cs)
Update adaptive runtime ServiceCollectionExtensions class to ensure middleware is added correctly.
Also added telephony to the channel constants.
Once this is merged the adaptive runtime implementation will need to be updated to remove the argument when adding the middleware.