Conversation
🚨 PR Check Failed - Critical Issues FoundFound 3 critical/error issue(s) that must be fixed. 🔍 Critical Issues Detected:
🤖 AI Analysis Summary:Brief Analysis: The spec file has been updated for a new release (6.6.104.2-4) and the only explicit patch (the mstflint patch) correctly uses a version‐parameter and is present in the package directory. The changelog mentions several CVE fixes, but none of these are referenced as separate patch files. Critical Issues Found: Recommended Actions: 📋 For detailed analysis and recommendations, check the Azure DevOps pipeline logs. |
Co-authored-by: Suresh Babu Chalamalasetty <schalam@microsoft.com>
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
To enable optimal DMA P2P support, AMD recommends enabling the following kernel configuration options:
CONFIG_PCI_P2PDMAEnables PCIe P2P DMA infrastructure in the kernel.
CONFIG_DMABUF_MOVE_NOTIFYAllows buffer movement notification required for certain peer-to-peer operations.
CONFIG_HSA_AMD_P2PEnables HSA (Heterogeneous System Architecture) support for AMD P2P, which is critical for ROCm.
Reference: AMD ROCm IOMMU Documentation
Change Log
Does this affect the toolchain?
YES
Associated issues
Links to CVEs
Test Methodology