Skip to content

Enable DMA P2P#14660

Merged
chalamalasetty merged 6 commits into3.0-devfrom
rlmenge/kernel/p2p
Oct 2, 2025
Merged

Enable DMA P2P#14660
chalamalasetty merged 6 commits into3.0-devfrom
rlmenge/kernel/p2p

Conversation

@rlmenge
Copy link
Contributor

@rlmenge rlmenge commented Sep 11, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

To enable optimal DMA P2P support, AMD recommends enabling the following kernel configuration options:

CONFIG_PCI_P2PDMA
Enables PCIe P2P DMA infrastructure in the kernel.

CONFIG_DMABUF_MOVE_NOTIFY
Allows buffer movement notification required for certain peer-to-peer operations.

CONFIG_HSA_AMD_P2P
Enables HSA (Heterogeneous System Architecture) support for AMD P2P, which is critical for ROCm.

Reference: AMD ROCm IOMMU Documentation

Change Log
  • Enable CONFIG_PCI_P2PDMA CONFIG_HSA_AMD CONFIG_HSA_AMD_P2P and dependency KConfigs
Does this affect the toolchain?

YES

Associated issues
Links to CVEs
Test Methodology
  • Pipeline build id: Local validation.

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Sep 11, 2025
@CBL-Mariner-Bot
Copy link
Collaborator

CBL-Mariner-Bot commented Sep 11, 2025

🚨 PR Check Failed - Critical Issues Found

Found 3 critical/error issue(s) that must be fixed.

🔍 Critical Issues Detected:

  1. Missing Patch File (ERROR)
    • Patch file '0001-add-mstflint-kernel-%{mstflintver}.patch' is referenced in the spec but not found in the directory
    • 💡 Fix: Add the missing patch file or update the Patch reference
  2. Missing Patch File (ERROR)
    • Patch file '0001-add-mstflint-kernel-%{mstflintver}.patch' is referenced in the spec but not found in the directory
    • 💡 Fix: Add the missing patch file or update the Patch reference
  3. Missing Patch File (ERROR)
    • Patch file '0001-add-mstflint-kernel-%{mstflintver}.patch' is referenced in the spec but not found in the directory
    • 💡 Fix: Add the missing patch file or update the Patch reference

🤖 AI Analysis Summary:

Brief Analysis: The spec file has been updated for a new release (6.6.104.2-4) and the only explicit patch (the mstflint patch) correctly uses a version‐parameter and is present in the package directory. The changelog mentions several CVE fixes, but none of these are referenced as separate patch files.

Critical Issues Found:
• No CVE-specific patch file directives (using “Patch: CVE-YYYY-XXXXX.patch”) are present—even though some changelog entries reference CVEs.

Recommended Actions:
• Confirm that CVE fixes mentioned in the changelog are handled upstream or incorporated into the source (document if so).
• If any CVE fixes require separate patches, add them with proper Patch numbering and %patch/%autopatch directives.
• Ensure changelog entries for CVE fixes clearly indicate their source/upstream attribution when no patch file is used.


📋 For detailed analysis and recommendations, check the Azure DevOps pipeline logs.

@chalamalasetty chalamalasetty marked this pull request as ready for review October 1, 2025 17:52
@chalamalasetty chalamalasetty requested review from a team as code owners October 1, 2025 17:52
@chalamalasetty chalamalasetty merged commit bf3f59a into 3.0-dev Oct 2, 2025
28 of 32 checks passed
@chalamalasetty chalamalasetty deleted the rlmenge/kernel/p2p branch October 2, 2025 06:16
jykanase pushed a commit to jykanase/azurelinux that referenced this pull request Oct 16, 2025
Co-authored-by: Suresh Babu Chalamalasetty <schalam@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants