Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
+ Coverage 27.76% 37.21% +9.44%
==========================================
Files 27 27
Lines 3493 3493
Branches 791 791
==========================================
+ Hits 970 1300 +330
+ Misses 2452 2073 -379
- Partials 71 120 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@gagb @qingyun-wu Do one of you have time to review this small change? |
gagb
approved these changes
Nov 28, 2023
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* Use tqdm to report progress in learn_from_user_feedback() * Update contrib-openai.yml Append `pytest-asyncio` to `pip install coverage` for TeachableAgent. * Replace pytest-asyncio with pytest * Temporary usage of pull_request action. * Restore pull_request_target action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
TeachableAgent.learn_from_user_feedbackcan take awhile to complete. This PR adds a progress bar.Returning immediately for asynchronous behavior is one option, but that would cause problems for all of the current teachability tests, which immediately start a new chat assuming that the vector DB has been fully updated. If an application needs asynchronous behavior, it can easily call
learn_from_user_feedbackfrom a separate process. But our focus for now is research, and the teachability mechanisms are still evolving.Related issue number
Closes #329
Checks