Skip to content

Grammar and spelling fixes for agentchat_RetrieveChat.ipynb#344

Closed
shruti222patel wants to merge 2 commits into
microsoft:mainfrom
shruti222patel:patch-4
Closed

Grammar and spelling fixes for agentchat_RetrieveChat.ipynb#344
shruti222patel wants to merge 2 commits into
microsoft:mainfrom
shruti222patel:patch-4

Conversation

@shruti222patel

Copy link
Copy Markdown
Contributor

Why are these changes needed?

For readability.

Related issue number

Checks

@shruti222patel

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Comment thread notebook/agentchat_RetrieveChat.ipynb Outdated
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
@codecov-commenter

codecov-commenter commented Oct 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #344 (fb31b70) into main (58b8c52) will not change coverage.
Report is 13 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   42.33%   42.33%           
=======================================
  Files          19       19           
  Lines        2393     2393           
  Branches      539      539           
=======================================
  Hits         1013     1013           
  Misses       1302     1302           
  Partials       78       78           
Flag Coverage Δ
unittests 42.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gagb

gagb commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator

@shruti222patel seems like this PR has conflicts with main. If you can update your commit, I can review it.

@qingyun-wu

Copy link
Copy Markdown
Contributor

Closing due to conflicts.

@qingyun-wu qingyun-wu closed this Dec 4, 2023
jackgerrits pushed a commit that referenced this pull request Oct 2, 2024
* Fixed numerous issues with orchestrator, related to 342'

* Refined prompts, and added max wall-clock time to orchestrators.

* Fixed formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants