run sync and async in async#1242
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1242 +/- ##
===========================================
+ Coverage 31.60% 50.94% +19.34%
===========================================
Files 32 32
Lines 4389 4387 -2
Branches 1024 1078 +54
===========================================
+ Hits 1387 2235 +848
+ Misses 2892 1946 -946
- Partials 110 206 +96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
I think your code is a correct bug fix, but not for #1205 (it is about 2 calls suggested in the same response). |
Contributor
Author
|
Yup was in progress :-) |
davorrunje
suggested changes
Jan 14, 2024
davorrunje
left a comment
Contributor
There was a problem hiding this comment.
Can you please uncomment the last cell in notebook/agentchat_function_call_async.ipynb?
Everything else looks good 👍
davorrunje
approved these changes
Jan 14, 2024
Contributor
|
LGTM 👍 |
joshkyh
pushed a commit
that referenced
this pull request
Jan 17, 2024
* run sync and async in async * test for async multitool call * uncomment notebook --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com> Co-authored-by: Davor Runje <davor@airt.ai>
Closed
3 tasks
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* run sync and async in async * test for async multitool call * uncomment notebook --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com> Co-authored-by: Davor Runje <davor@airt.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Run sync tools in async to match behavior of functions in parallel tool calling
Related issue number
Closes #1205
Checks