Fix virtual package orphan detection in deps list#23
Merged
danielmeppiel merged 1 commit intomainfrom Oct 30, 2025
Merged
Conversation
Virtual packages with extensions like .prompt.md were incorrectly flagged as orphaned because the comparison used raw repo_url instead of the sanitized virtual package name. Now correctly builds expected package names using get_virtual_package_name() for virtual packages, matching the installation folder structure.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the orphaned package detection logic in the apm deps list command to properly handle virtual packages. Previously, the code was comparing the raw repo_url against installed package names, which failed for virtual packages that use a sanitized naming scheme.
Key Changes
- Updated orphaned package detection to use the same naming convention for virtual packages (
org/repo-name-package-name) as used during installation - Maintained existing behavior for regular packages (
org/repo-name) - Aligned the logic with the existing implementation in
cli.py
danielmeppiel
added a commit
that referenced
this pull request
Mar 9, 2026
- Dynamic package type in synthesized apm.yml based on actual components (#12) - Name validation warning in parse_plugin_manifest (#13) - Clean .prompt.md rename logic (#14) - Install counter includes cached packages (#15) - Package type persisted in lockfile (#17) - Custom component path arrays from plugin.json (#23) - README: plugin as supported source, awesome-copilot example, docs link - CHANGELOG: unreleased entry for plugin support - docs: MARKETPLACE_PLUGIN in manifest-schema, dependencies, primitives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtual packages with extensions like .prompt.md were incorrectly flagged as orphaned by
apm deps listbecause the comparison used raw repo_url instead of the sanitized virtual package name.Now correctly builds expected package names using get_virtual_package_name() for virtual packages, matching the installation folder structure.