Skip to content

feat(ai-scan-support): add support for showing ai-scan guidance tag in reports#7570

Merged
v-viyada merged 6 commits intomicrosoft:mainfrom
ashkan0x:main
Apr 10, 2025
Merged

feat(ai-scan-support): add support for showing ai-scan guidance tag in reports#7570
v-viyada merged 6 commits intomicrosoft:mainfrom
ashkan0x:main

Conversation

@ashkan0x
Copy link
Copy Markdown
Member

@ashkan0x ashkan0x commented Apr 4, 2025

Details

This PR introduces support for ai-scan guidance tags, which should behave similarly to the existing "Best Practice" tag, i.e. an "AI Suggested" pill will be shown in the reports where applicable.

image
image

Motivation

Distinguishes between axe-core and AI-detected issues in the reports, making it easier for users to understand the origin of the issue.

Context

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@ashkan0x ashkan0x requested a review from a team as a code owner April 4, 2025 11:13
@ashkan0x
Copy link
Copy Markdown
Member Author

ashkan0x commented Apr 4, 2025

@microsoft-github-policy-service agree company="Microsoft"

@ashkan0x ashkan0x changed the title feat(ai-scan-guidance-tag): add support for showing ai-scan guidance tag in reports feat(ai-scan-support): add support for showing ai-scan guidance tag in reports Apr 4, 2025
@ashkan0x
Copy link
Copy Markdown
Member Author

ashkan0x commented Apr 4, 2025

@microsoft/accessibility-insights-code-owners Could you please take a look at this PR?

Copy link
Copy Markdown
Contributor

@homitc homitc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@v-viyada v-viyada merged commit 9024285 into microsoft:main Apr 10, 2025
11 checks passed
v-viyada pushed a commit that referenced this pull request Apr 22, 2025
…tton (only for HTML reports) (#7576)

This PR follows:
#7570

#### Details

<!-- Usually a sentence or two describing what the PR changes -->

- Feedback mechanism is enabled when `feedbackURL` is provided AND the
issue's guidance matches `AI_SCAN`
- Copy failure details button is implemented for HTML reports


https://github.com/user-attachments/assets/c2f74853-67d8-4869-ac25-20887a1616a8

##### Motivation

<!-- This can be as simple as "addresses issue #123" -->

##### Context

<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->

<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [ ] Addresses an existing issue: #0000
- [ ] Ran `yarn fastpass`
- [ ] Added/updated relevant unit test(s) (and ran `yarn test`)
- [ ] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [ ] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [ ] (UI changes only) Added screenshots/GIFs to description above
- [ ] (UI changes only) Verified usability with NVDA/JAWS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants