Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.

Updating cert with expiration date for another year.#1163

Merged
pradipd merged 2 commits into
microsoft:developfrom
pradipd:develop
Oct 17, 2016
Merged

Updating cert with expiration date for another year.#1163
pradipd merged 2 commits into
microsoft:developfrom
pradipd:develop

Conversation

@pradipd

@pradipd pradipd commented Oct 17, 2016

Copy link
Copy Markdown
Contributor
  1. Updated the cert using VS directions under "Renew a certification" at https://msdn.microsoft.com/en-us/library/br230260.aspx. The cert is valid for another year.
  2. Updated VSImporter to use publisher="CN=islandwood" instead of publisher="islandwood". I think this is due to changes in latest SDK. I'm not sure how to check if this is backwards compatible as I don't have a machine without 14393 SDK.

@pradipd

pradipd commented Oct 17, 2016

Copy link
Copy Markdown
Contributor Author

@rajsesh-msft is added to the review. #Closed

<Identity
Name="$guid9$"
Publisher="islandwood"
Publisher="CN=islandwood"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CN=islandwood [](start = 15, length = 13)

I'm nervous about backwards compat. Does anyone have a machine without 14393?
How can we validate we won't break external developers who haven't installed 14393 SDK.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CN= format has always worked in the past I can see several examples of this in our internal codebase, so this should pose any compat issues.


In reply to: 83706840 [](ancestors = 83706840)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur. I tried building your branch on my machine with only 10.0.10586.0 installed, and everything looked to be OK.


In reply to: 83711603 [](ancestors = 83711603,83706840)

@rajsesh

rajsesh commented Oct 17, 2016

Copy link
Copy Markdown
Contributor

:shipit:

@pradipd

pradipd commented Oct 17, 2016

Copy link
Copy Markdown
Contributor Author

Looks like Oct, 14-17, 2016 was a momentous date. Since I started this change, many of the samples started failing because the keys for their apps expired.
I went back and update all the keys to use the one from msvc\vsiimporter-templates\WinStore10-App

I also updated all the *.appxmanifest. I'm not sure why they don't show up in the pull request though.

@asimonov-msft

Copy link
Copy Markdown
Contributor

You should be able to remove the following directories, as they are obsolete:
samples\WOCCatalog\WOCCatalog.vsimporter\WOCCatalog-Headers-WinStore10
samples\XAMLCatalog\XAMLCatalog.vsimporter\XAMLCatalog-Headers-WinStore10


In reply to: 254308466 [](ancestors = 254308466)

@asimonov-msft

Copy link
Copy Markdown
Contributor

:shipit:

@pradipd pradipd merged commit 212dba2 into microsoft:develop Oct 17, 2016
@edvv

edvv commented Oct 19, 2016

Copy link
Copy Markdown

FYI: I got bit by this expiring cert so had to set the date back two weeks; but then the AppManifest.xml showed with an invalid schema due to the lack of CN= pattern, which is strange because it worked before. I manually edited the pattern to get it to complete the build.

Short story: It would be nice to fold this change into a new release ASAP (release 42).

aballway pushed a commit to aballway/WinObjC that referenced this pull request Oct 19, 2016
* Updating cert with expiration date for another year.

* Updating keys for all the other apps as they are set to expire.
@rajsesh

rajsesh commented Oct 19, 2016

Copy link
Copy Markdown
Contributor

@edvv, we will have this in the next release, which would be in early November.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants