Bridge NS and CFStream as well as make CF components use Ebr function… by bbowman · Pull Request #1137 · microsoft/WinObjC

bbowman · 2016-10-13T00:14:38Z

…s for interoperabilty. This is a prestep to unify the file handling mechanics through stream and data instead of direct reliance on Ebr functions.

bbowman · 2016-10-13T00:24:12Z

@ms-jihua is added to the review. #Closed

bbowman · 2016-10-13T00:24:17Z

@rajsesh-msft is added to the review. #Closed

DHowett-MSFT · 2016-10-13T00:25:48Z

+        ret->st_size = 0;
+        ret->st_mode = 0x1B6 | 0040000;
+        // MurmurHash3_x86_32(assetName, strlen(assetName), 0, &ret->st_ino);
+        return 0;


No point in keeping commented code #Resolved

We were faking inodes for .. some .. reason?

In reply to: 83125758 [](ancestors = 83125758)

I have no clue. This was a mostly copied version to support 64i32 versions of things. but sure I'll remove commented out line in both.

In reply to: 83125777 [](ancestors = 83125777,83125758)

bbowman · 2016-10-13T00:26:42Z

#1099
extend fopen to look for things in Windows.Storage.AccessCache is what this works towards. The basic steps are:

Bridge use of CF/NSStream
Consolidate Ebr usage across repo to use Stream
Enhance underlying support for storage file.

DHowett-MSFT · 2016-10-13T00:28:32Z

+#define fstat _NS_fstat
+#define mkdir(a,b) _NS_mkdir(a)
+#define rmdir _NS_rmdir
+#define unlink _NS_unlink


It worries me that these are scatted across so many files, but I see that that is a la mode #WontFix

I agree but I thought putting these in a commonly included header would be a bit much as I don't really want to #def something like open unless I'm pretty sure its only used in a file sense. some other terms there are pretty common words so I felt a little better about it and it is obviously the system CF is already expecting so yes. Worrisome but the best of a bad situation?

In reply to: 83126012 [](ancestors = 83126012)

DHowett-MSFT · 2016-10-13T00:29:24Z

+
+    char path[CFMaxPathSize];
 #if DEPLOYMENT_TARGET_WINDOWS
-    wchar_t path[CFMaxPathSize];


wchar_t path[CFMaxPathSize]; [](start = 4, length = 28)

Does this change need a WINOBJC comment? #Resolved

it could but its not a change needed specifically for us as the normal impl of _NS_open calls _wopen. It was just to have better code reuse but will comment anyway.

In reply to: 83126093 [](ancestors = 83126093)

DHowett-MSFT · 2016-10-13T00:29:54Z

+#import <CFFoundationInternal.h>
+
+#import <StubReturn.h>
+


unused iiuc #Resolved

DHowett-MSFT · 2016-10-13T00:30:33Z

+#import <CoreFoundation/CFStream.h>
+#import <CFFoundationInternal.h>
+
+#import <StubReturn.h>


StubReturn [](start = 9, length = 10)

as before #Resolved

MSFTFox · 2016-10-13T00:39:31Z

+}
+
+/**
+ @Status Stub


Stub [](start = 9, length = 4)

Not a stub? #Resolved

MSFTFox · 2016-10-13T00:51:12Z

+        return -1;
+    }
+
+    char* assetName = fixedName + 1;


assetName [](start = 10, length = 9)

Unused. Unused above as well in a similar function. #Resolved

rajsesh · 2016-10-13T01:57:29Z

+    if (ensureFilesWithContents(fileNames, contents))
+
+    {
+        return fileNames[0];


nit: clang format run amok? #Resolved

rajsesh · 2016-10-13T02:03:19Z

ms-jihua · 2016-10-13T20:48:11Z

+#define lseek _NS_lseek
+#else
+#define statinfo _stat
 #define stat(x,y) _stat64i32(x,y)


should this comment stay there? #ByDesign

no. Every other file had it as _stat64i32 so that is almost assuredly the right thing.

In reply to: 83308434 [](ancestors = 83308434)

ms-jihua · 2016-10-13T20:50:07Z

+/**
+ @Status Interoperable
+*/
+- (id)initWithData:(id)data {


nit: can you fix the signatures here? #Resolved

ms-jihua · 2016-10-13T20:52:55Z

+/**
+ @Status Interoperable
+*/
+- (int)read:(uint8_t*)buf maxLength:(NSUInteger)maxLength {


int [](start = 3, length = 3)

nit: NSInteger #Resolved

ms-jihua · 2016-10-13T20:53:32Z

+/**
+ @Status Interoperable
+*/
+- (unsigned)streamStatus {


unsigned [](start = 3, length = 8)

nit: NSStreamStatus (in nscfoutputstream also) #Resolved

ms-jihua · 2016-10-13T20:54:45Z

 /**
 @Status Interoperable
 */
 + (id)inputStreamWithFileAtPath:(id)file {


signatures etc etc. not sure whether you'll fix in the NSCF files but I think they should be correct in the NS files at least. #Resolved

ms-jihua · 2016-10-13T20:56:19Z

+
+#include <CoreFoundation/CFStream.h>

 FOUNDATION_EXPORT NSString* const NSStreamSocketSecurityLevelKey = @"NSStreamSocketSecurityLevelKey";


the rest of these ought to have CF equivalents also?

ms-jihua · 2016-10-13T20:58:49Z

…s for interoperabilty. This is a prestep to unify the file handling mechanics through stream and data instead of direct reliance on Ebr functions.

microsoft#1137) Bridge NS and CFStream as well as make CF components use Ebr functions for interoperabilty. Description: Bridge NS and CFStream as well as make CF components use Ebr functions for interoperabilty. This is a prestep to unify the file handling mechanics through stream and data instead of direct reliance on Ebr functions. Works towards microsoft#1099 extend fopen to look for things in Windows.Storage.AccessCache is what this works towards. The basic steps are: 1. Bridge use of CF/NSStream 2. Consolidate Ebr usage across repo to use Stream 3. Enhance underlying support for storage file. How verified: New UTs and old UTs Reviewed-by: rajseh-msft, ms-jihua

msftclas added the cla-not-required label Oct 13, 2016

DHowett-MSFT reviewed Oct 13, 2016

View reviewed changes

MSFTFox reviewed Oct 13, 2016

View reviewed changes

rajsesh added the Area-Foundation label Oct 13, 2016

rajsesh reviewed Oct 13, 2016

View reviewed changes

ms-jihua reviewed Oct 13, 2016

View reviewed changes

bbowman added 4 commits October 13, 2016 14:28

Bridge NS and CFStream as well as make CF components use Ebr function…

1ee21b3

…s for interoperabilty. This is a prestep to unify the file handling mechanics through stream and data instead of direct reliance on Ebr functions.

s

24fc9da

s

eae00f6

s

0520688

bbowman force-pushed the bbowman/bridgeStream_pr branch from a7771cb to 0520688 Compare October 13, 2016 23:11

Merge branch 'develop' into bbowman/bridgeStream_pr

5c44382

bbowman merged commit ef0ec9d into microsoft:develop Oct 13, 2016


		#include <CoreFoundation/CFStream.h>

		FOUNDATION_EXPORT NSString* const NSStreamSocketSecurityLevelKey = @"NSStreamSocketSecurityLevelKey";

		#import <CFFoundationInternal.h>

		#import <StubReturn.h>

Conversation

bbowman commented Oct 13, 2016

Uh oh!

bbowman commented Oct 13, 2016

Uh oh!

bbowman commented Oct 13, 2016

Uh oh!

DHowett-MSFT Oct 13, 2016 • edited by bbowman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DHowett-MSFT Oct 13, 2016

Choose a reason for hiding this comment

Uh oh!

bbowman Oct 13, 2016

Choose a reason for hiding this comment

Uh oh!

bbowman commented Oct 13, 2016

Uh oh!

DHowett-MSFT Oct 13, 2016 • edited by bbowman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bbowman Oct 13, 2016

Choose a reason for hiding this comment

Uh oh!

DHowett-MSFT Oct 13, 2016 • edited by bbowman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bbowman Oct 13, 2016

Choose a reason for hiding this comment

Uh oh!

DHowett-MSFT Oct 13, 2016 • edited by bbowman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DHowett-MSFT Oct 13, 2016 • edited by bbowman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MSFTFox Oct 13, 2016 • edited by bbowman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MSFTFox Oct 13, 2016 • edited by bbowman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajsesh Oct 13, 2016 • edited by bbowman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajsesh commented Oct 13, 2016

Uh oh!

ms-jihua Oct 13, 2016 • edited by bbowman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bbowman Oct 13, 2016

Choose a reason for hiding this comment

Uh oh!

ms-jihua Oct 13, 2016 • edited by bbowman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ms-jihua Oct 13, 2016 • edited by bbowman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ms-jihua Oct 13, 2016 • edited by bbowman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ms-jihua Oct 13, 2016 • edited by bbowman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ms-jihua Oct 13, 2016

Choose a reason for hiding this comment

DHowett-MSFT Oct 13, 2016 •

edited by bbowman

Loading

DHowett-MSFT Oct 13, 2016 •

edited by bbowman

Loading

DHowett-MSFT Oct 13, 2016 •

edited by bbowman

Loading

DHowett-MSFT Oct 13, 2016 •

edited by bbowman

Loading

DHowett-MSFT Oct 13, 2016 •

edited by bbowman

Loading

MSFTFox Oct 13, 2016 •

edited by bbowman

Loading

MSFTFox Oct 13, 2016 •

edited by bbowman

Loading

rajsesh Oct 13, 2016 •

edited by bbowman

Loading

ms-jihua Oct 13, 2016 •

edited by bbowman

Loading

ms-jihua Oct 13, 2016 •

edited by bbowman

Loading

ms-jihua Oct 13, 2016 •

edited by bbowman

Loading

ms-jihua Oct 13, 2016 •

edited by bbowman

Loading

ms-jihua Oct 13, 2016 •

edited by bbowman

Loading