Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.

Updating all VS projects to target the RS1 SDK.#1122

Merged
asimonov-msft merged 2 commits into
microsoft:developfrom
asimonov-msft:rs1_sdk
Oct 12, 2016
Merged

Updating all VS projects to target the RS1 SDK.#1122
asimonov-msft merged 2 commits into
microsoft:developfrom
asimonov-msft:rs1_sdk

Conversation

@asimonov-msft

Copy link
Copy Markdown
Contributor

No description provided.

@aballway

aballway commented Oct 11, 2016

Copy link
Copy Markdown
Contributor

Is this the change required for #1048? #Resolved

@DHowett-MSFT

DHowett-MSFT commented Oct 11, 2016

Copy link
Copy Markdown

While we are here, can we bring up the TargetPlatformVersionMin? #Resolved

@DHowett-MSFT

DHowett-MSFT commented Oct 11, 2016

Copy link
Copy Markdown

Sorry, I mean to bring up min to 10586. #Resolved

@asimonov-msft

Copy link
Copy Markdown
Contributor Author

Our WindowsTargetPlatformMinVersion should already be at 10.0.10586.0. Is that not so?


In reply to: 252996479 [](ancestors = 252996479)

@asimonov-msft

Copy link
Copy Markdown
Contributor Author

No idea.


In reply to: 252994573 [](ancestors = 252994573)

@DHowett-MSFT

Copy link
Copy Markdown

Half our projects are at 10240 right now :)


In reply to: 253002438 [](ancestors = 253002438,252996479)

@bbowman

bbowman commented Oct 11, 2016

Copy link
Copy Markdown
Member

Why do we want to update our min?


In reply to: 253003067 [](ancestors = 253003067,253002438,252996479)

@bbowman

bbowman commented Oct 11, 2016

Copy link
Copy Markdown
Member

hmm got a little confused here but it is true that we use 10586 stuff and don't do a "fantastic" job of back compat so I approve.


In reply to: 253011472 [](ancestors = 253011472,253003067,253002438,252996479)

@bbowman

bbowman commented Oct 11, 2016

Copy link
Copy Markdown
Member

(Does look like your build failed though so check that out)


In reply to: 253017160 [](ancestors = 253017160,253011472,253003067,253002438,252996479)

@bbowman

bbowman commented Oct 11, 2016

Copy link
Copy Markdown
Member

:shipit:

1 similar comment
@DHowett-MSFT

Copy link
Copy Markdown

:shipit:

@asimonov-msft

Copy link
Copy Markdown
Contributor Author

The first round of builds failed because the server was missing the RS1 SDK. I fixed that.


In reply to: 253017271 [](ancestors = 253017271,253017160,253011472,253003067,253002438,252996479)

@asimonov-msft asimonov-msft merged commit e850555 into microsoft:develop Oct 12, 2016
yiyang-msft added a commit that referenced this pull request Oct 14, 2016
yiyang-msft added a commit that referenced this pull request Oct 15, 2016
aballway pushed a commit to aballway/WinObjC that referenced this pull request Oct 19, 2016
* Update all VS projects to target the RS1 SDK.
* Bring up TargetPlatformMinVersion to 10.0.10586.0 for a few missed projects.
aballway pushed a commit to aballway/WinObjC that referenced this pull request Oct 19, 2016
asimonov-msft added a commit to asimonov-msft/WinObjC that referenced this pull request Nov 1, 2016
asimonov-msft added a commit to asimonov-msft/WinObjC that referenced this pull request Jan 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants