This repository was archived by the owner on May 28, 2025. It is now read-only.
Tweak ci build script to support CI build targeting any source branch.#1118
Merged
Conversation
* Added support to explicitly specify source branch. * Note: Source branch could probably be determined from upstream remote, * but it is not very reliable. Also, explicit parameter allows kicking * off arbitrary builds. Fix #1089
Contributor
Author
|
@DHowett-MSFT is added to the review. #Closed |
| [switch]$Reconfigure, | ||
| [switch]$SkipRemoteCheck, | ||
| [string]$BuildFilter, | ||
| [string]$SourceBranch='develop', |
There was a problem hiding this comment.
[](start = 0, length = 1)
nit: Tab, should be four spaces #Pending
| } | ||
| If ($definitionSet.ConfigMappings.SourceBranch) { | ||
| $requestBody.sourceBranch = $definitionSet.ConfigMappings.SourceBranch.Replace("`$BRANCH", $Ref) | ||
| $requestBody.sourceBranch = $definitionSet.ConfigMappings.SourceBranch.Replace("`$BRANCH", $SourceBranch) |
There was a problem hiding this comment.
$BRANCH [](start = 89, length = 7)
I'd prefer another variable here, like $BASE or $SOURCE.
In the far future, if VSO ever gets the ability to specify a repo and ref as the source, we can move away from the pull request merge-in and use Ref directly. #Pending
There was a problem hiding this comment.
(So we keep BRANCH for "the thing the user wants built" in all of the cases :))
In reply to: 82856817 [](ancestors = 82856817)
|
|
aballway
pushed a commit
to aballway/WinObjC
that referenced
this pull request
Oct 19, 2016
microsoft#1118) * Removed deprecated build definitions. * Added support to explicitly specify source branch. * Note: Source branch could probably be determined from upstream remote, * but it is not very reliable. Also, explicit parameter allows kicking * off arbitrary builds. Fix microsoft#1089
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1089