This repository was archived by the owner on May 28, 2025. It is now read-only.
Always create solution folders when importing, since they are useful for build telemetry#1117
Merged
asimonov-msft merged 1 commit intoOct 14, 2016
Conversation
d5e4589 to
675703b
Compare
aballway
approved these changes
Oct 11, 2016
| // The solution folder is necessary for VS build telemetry to work properly. | ||
| VSSolutionFolderProject* projFolder = NULL; | ||
| if (m_existingTargets.size() > 1) { | ||
| if (m_existingTargets.size() > 0) { |
Contributor
There was a problem hiding this comment.
Is this check necessary since you already return if it's empty? #Resolved
Contributor
Author
There was a problem hiding this comment.
You are technically correct. The best kind of correct.
In reply to: 82833190 [](ancestors = 82833190)
675703b to
567c8b3
Compare
567c8b3 to
bfd85b8
Compare
…for build telemetry.
bfd85b8 to
889777e
Compare
aballway
pushed a commit
to aballway/WinObjC
that referenced
this pull request
Oct 19, 2016
…for build telemetry. (microsoft#1117)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.