Convert sbAssert and sbValidate into sbAssertWithTelemetry and sbValidateWithTelemetry#1104
Conversation
| void queryListSelection(const StringVec& values, const String& queryMessage, const String& itemName, std::vector<size_t>& ret) | ||
| { | ||
| sbAssert(!values.empty()); | ||
| sbAssertWithTelemetry(!values.empty(), "Unable to query empty list of values"); |
There was a problem hiding this comment.
sbAssertWithTelemetry(!values.empty(), "Unable to query empty list of values"); [](start = 2, length = 79)
Would the query message be helpful here? I'm not sure if the query would contain Personally Identifiable Information (PII) or not. #Resolved
There was a problem hiding this comment.
| bool useRelativePath = true; | ||
| if (itemHint && !itemHint->pathOverride.empty()) { | ||
| sbAssert(!isVariant, "Unexpected path override for variant file: " + realPath); | ||
| sbAssertWithTelemetry(!isVariant, "Unexpected path override for variant file: " + realPath); |
There was a problem hiding this comment.
realPath [](start = 86, length = 8)
Could this path contain PII, like a user name, e.g. /mymac/kellymor/projects/ ? Or is this handled by the call to sbAssertWithTelemetry? If the latter, then disregard this comment. #Resolved
There was a problem hiding this comment.
The path does contain PI, but it will be stripped off since it comes after the colon.
In reply to: 82424365 [](ancestors = 82424365)
2059dc6 to
d32c612
Compare
|
|
78ce83c to
7efbf6b
Compare
7efbf6b to
e75def3
Compare
…dateWithTelemetry.
e75def3 to
d31fc43
Compare
…dateWithTelemetry. (microsoft#1104)
No description provided.