feat: Simplified Chinese language support by aykhara · Pull Request #948 · microsoft/VoTT

aykhara · 2020-03-24T11:18:25Z

Simplified Chinese translation verified by @siliang-jiao

* small fix * small fix * small fix * small fixes

mydiemho

Please build a version locally and make sure all strings are rendered correctly. In the process of translation, a lot of the variables extrapolations are messed up. I mark some below but not all please double check

mydiemho · 2020-03-26T17:55:31Z

src/common/localization/zh-ch.ts

+        instructions: "请选择一个连接进行编辑", // Please select a connection to edit
+        save: "保存连接", // Save Connection
+        messages: {
+            saveSuccess: "已成功保存$ {connection.name}", // Successfully saved ${connection.name}


there should not be a space between $ and ${connection.name}. Same for everywhere else a variable is use.

@mydiemho Thank you for reviewing very carefully. I just updated it to fix variables.

mydiemho

I would recommend using the phrases from the Traditional Chinese PR #949 , the translation there are easier to understand than the phrases use here. The phrases here seem to be more direct translation of the English phrases that doesn't take into usage context

mydiemho · 2020-03-29T22:46:05Z

src/common/localization/zh-ch.ts

+            },
+            rename: {
+                title: "重命名标签", // Rename Tag
+                confirmation: "您确定要重命名此标签吗？它将在所有资产中重命名",


I recommend looking at the Traditional Chinese pr and make this the same. The translation here is a little bit awkward. The phrase for "renaming" here is using the technical translation 重命名 whereas the other PR used a more common phrase that is understandable for everyone.

thanks @mydiemho changed 重命名 to 重新命名 and also 资产 to 素材.

buhongw7583c · 2020-04-09T02:58:32Z

src/common/localization/zh-ch.ts

+        help: "帮助", // Help
+        minimize: "最小化", // Minimize
+        maximize: "最大化", // Maximize
+        restore: "恢复", // Restore


“复原”would be better translation

I'm not sure in Chinese we call it “窗口化” right? I need find a Chinese operating system to confirm

yes “窗口化” it could be batter I think.

Is 窗口化 a computer science terminology or common user terminology?

@mydiemho I would say not very common user terminology. but this word is quite used in software translations. "复原" sounds more common.

changed to 复原

buhongw7583c · 2020-04-09T02:59:48Z

src/common/localization/zh-ch.ts

+                title: "名称", // Name
+            },
+            key: {
+                title: "键", // Key


"密钥“is more accurate

changed to 密钥

buhongw7583c · 2020-04-09T03:00:05Z

src/common/localization/zh-ch.ts

+            // Security tokens are used to encrypt sensitive data within your project configuration
+        },
+        version: {
+            description: "版：", // Version:


changed to 版本

Nick287 · 2020-04-09T03:18:12Z

src/common/localization/zh-ch.ts

+        help: "帮助", // Help
+        minimize: "最小化", // Minimize
+        maximize: "最大化", // Maximize
+        restore: "恢复", // Restore


I'm not sure in Chinese we call it “窗口化” right? I need find a Chinese operating system to confirm

Nick287 · 2020-04-09T03:20:43Z

src/common/localization/zh-ch.ts

+            // We recommend you backup the project file first.
+        },
+        messages: {
+            deleteSuccess: "已成功删除${project.name}", // Successfully deleted ${project.name}


删除成功 would be better

@Nick287 thanks for comment.
there is also a project.name attached, so it will be like
删除成功XXX项目
so I thought may be
成功删除XXX项目
maybe better?

Nick287 · 2020-04-09T03:24:28Z

src/common/localization/zh-ch.ts

+        },
+        save: "保存项目", // Save Project
+        sourceConnection: {
+            title: "源连接", // Source Connection


I vote for 源连接

Nick287 · 2020-04-09T03:28:43Z

src/common/localization/zh-ch.ts

+        help: "帮助", // Help
+        minimize: "最小化", // Minimize
+        maximize: "最大化", // Maximize
+        restore: "恢复", // Restore


yes “窗口化” it could be batter I think.

Nick287 · 2020-04-09T03:29:50Z

src/common/localization/zh-ch.ts

+    tags: {
+        title: "标签", // Tags
+        placeholder: "新增标签", // Add new tag
+        editor: "标签编辑器", // Tags Editor


编辑标签

changed to '编辑标签'. although in English translation there is the word 'editor', but '编辑器' does not exist anywhere else and not common to understand. thus changed to simpler phase as just '编辑标签'.

also changed ‘新增标签’ to ‘添加标签’. (since 'add new connection' has been translated to '添加连接' instead of '新增连接'). moreover, '添加' is definitely verb while '新增' could be misunderstood as adj.

Nick287 · 2020-04-09T03:30:47Z

src/common/localization/zh-ch.ts

+            olive: "橄榄色", // Olive
+            lime: "青色", // Lime
+            green: "绿色", // Green
+            aqua: "水色", // Aqua


浅绿色？

changed to '浅绿色'

Nick287 · 2020-04-09T03:31:44Z

src/common/localization/zh-ch.ts

+    },
+    connections: {
+        title: "连接数", // Connections
+        details: "连接细节", // Connection Details


链接详细信息

changed to 链接详细信息

Nick287 · 2020-04-09T03:43:38Z

src/common/localization/zh-ch.ts

+                },
+                modelUrl: {
+                    title: "模型 URL", // Model URL
+                    description: "从公共网址加载模型", // Load your model from a public web URL


从网络链接加载模型

I vote for 从公共网址加载模型

mydiemho · 2020-04-09T17:02:24Z

src/common/localization/zh-ch.ts

+            description: "从何处加载素材", // Where to load assets from
+        },
+        targetConnection: {
+            title: "目标连接", // Target Connection


连接目标

changed to 连接目标

sonarqubecloud · 2020-04-28T07:18:06Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

mydiemho · 2020-04-28T16:15:33Z

will merge despite missing codecov report b/c Codecov is having issues reporting to GitHub. The coverage for this pr is above threshold https://codecov.io/gh/Microsoft/vott/commit/27dde35b4b9bf76082c978a1a7422c20d0927f57

tbarlow12 and others added 5 commits October 4, 2019 16:05

fix: Update new link for VoTT site (microsoft#907)

c1afb7e

feat: Simplified Chinese language support

840b512

Patch 1 (#1)

2adefe7

* small fix * small fix * small fix * small fixes

Fix conflict files and tslint errors

0d9517d

Fix conflict files and tslint errors

b85576d

mydiemho suggested changes Mar 26, 2020

View reviewed changes

Fix variables for simplified Chinese

c8b02fb

mydiemho suggested changes Mar 29, 2020

View reviewed changes

siliang-j-1225 added 4 commits March 30, 2020 10:54

update translation of 'rename'

91a3480

update 'assets' from '资产' to '素材'

94d8401

small fix

e0aaaf6

small fixes

de0d858

buhongw7583c reviewed Apr 9, 2020

View reviewed changes

Nick287 reviewed Apr 9, 2020

View reviewed changes

mydiemho reviewed Apr 9, 2020

View reviewed changes

siliang-j-1225 added 3 commits April 10, 2020 11:25

fixes based on comments

2faef15

fixes based on comments

42b3363

small fixes

7ad02ed

mydiemho approved these changes Apr 21, 2020

View reviewed changes

PIC123 approved these changes Apr 21, 2020

View reviewed changes

Fix conflicts

27dde35

mydiemho merged commit 347f609 into microsoft:develop Apr 28, 2020

Conversation

aykhara commented Mar 24, 2020

Uh oh!

mydiemho left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mydiemho left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 28, 2020

Uh oh!

mydiemho commented Apr 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone