feat: Traditional Chinese language support#949
Conversation
harvinchou
left a comment
There was a problem hiding this comment.
The translation is good! Just provided some suggested changes to make them more align with Azure's official terms.
Co-Authored-By: Jason Chou <harvinchou@hotmail.com>
accepted suggestion. thanks for the feedback those make sense! Co-Authored-By: Jason Chou <harvinchou@hotmail.com>
ShuyuanChang
left a comment
There was a problem hiding this comment.
I had suggested some general terms and pls check them.
thanks for the review, this is more close to normally a TW UI wording! appreciated! Co-Authored-By: John Chang <john.chang@microsoft.com>
mydiemho
left a comment
There was a problem hiding this comment.
Please build a version locally and make sure all strings are rendered correctly. In the process of translation, a lot of the variables extrapolations are messed up. I mark some below but not all please double check
src/common/localization/zh-tw.ts
Outdated
| }, | ||
| importProject: { | ||
| title: "匯入專案", // Import Project | ||
| confirmation: "您確定要將專案$ {project.file.name}的設定轉換為v2格式嗎？我們建議您首先備份專案文件。", |
There was a problem hiding this comment.
please remove the space between $ and {project.file.name}.
src/common/localization/zh-tw.ts
Outdated
| // We recommend you backup the project file first. | ||
| }, | ||
| messages: { | ||
| deleteSuccess: "已成功刪除$ {project.name}專案", // Successfully deleted ${project.name} |
src/common/localization/zh-tw.ts
Outdated
| }, | ||
| addConnection: "新增連線", // Add Connection | ||
| messages: { | ||
| saveSuccess: "已成功保存$ {project.name}專案設定", // Successfully saved ${project.name} project settings |
src/common/localization/zh-tw.ts
Outdated
| // As for this VOTT tool, translate "Assets" to "Image data" in Traditional Chinese, | ||
| // as "Asset" can be confusing if directly translated. | ||
| totalAssetCount: "圖像數據總數", // Total Assets | ||
| visitedAssets: "已檢視的圖像數據（$ {count}）", // Visited Assets (${count}) |
…rocess. thanks My Ho for pointing out!!
|
Kudos, SonarCloud Quality Gate passed!
|
thanks @mydiemho , I just updated 9 occurrence of those and committed. |
Traditional Chinese translation verified by @rextangtw