Skip to content
This repository was archived by the owner on Dec 7, 2021. It is now read-only.

fix: Correctly save the ymax value on PascalVOC exporter and remove Tensorflow name#763

Merged
wbreza merged 1 commit intodevelopfrom
jamangia/fix-pascal-voc-ymax
Apr 15, 2019
Merged

fix: Correctly save the ymax value on PascalVOC exporter and remove Tensorflow name#763
wbreza merged 1 commit intodevelopfrom
jamangia/fix-pascal-voc-ymax

Conversation

@JacopoMangiavacchi
Copy link
Copy Markdown
Contributor

@JacopoMangiavacchi JacopoMangiavacchi commented Apr 15, 2019 •
edited by mydiemho
Loading

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2019

Codecov Report

Merging #763 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #763   +/-   ##
========================================
  Coverage    87.03%   87.03%           
========================================
  Files          125      125           
  Lines         4396     4396           
  Branches       834      834           
========================================
  Hits          3826     3826           
  Misses         568      568           
  Partials         2        2
Impacted Files Coverage Δ
src/common/localization/es-cl.ts 100% <ø> (ø) ⬆️
src/common/strings.ts 100% <ø> (ø) ⬆️
src/common/localization/en-us.ts 100% <ø> (ø) ⬆️
src/providers/export/tensorFlowRecords.ts 71.95% <ø> (ø) ⬆️
...c/providers/export/pascalVOC/pascalVOCTemplates.ts 100% <ø> (ø)
src/providers/export/pascalVOC.ts 84.21% <100%> (ø)
src/registerProviders.ts 80% <100%> (ø) ⬆️
src/common/mockFactory.ts 86.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7399523...7d96281. Read the comment docs.

wbreza
wbreza approved these changes Apr 15, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pjlittle
Copy link
Copy Markdown
Collaborator

pjlittle commented Apr 15, 2019

glad we got the name straightened out 🙂

@wbreza wbreza merged commit b13eaf6 into develop Apr 15, 2019
@JacopoMangiavacchi JacopoMangiavacchi deleted the jamangia/fix-pascal-voc-ymax branch April 16, 2019 02:41
wbreza pushed a commit that referenced this pull request Apr 29, 2019
@JacopoMangiavacchi @wbreza
Fix ymax and rename Tensorflow nama everywhere (#763)
39521f2 
fix issue #760 [AB#18223]
@Z3r0S3v3n Z3r0S3v3n mentioned this pull request Sep 28, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@pjlittle pjlittle pjlittle approved these changes

@wbreza wbreza wbreza approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JacopoMangiavacchi @pjlittle @wbreza