This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Conversation
pjlittle
reviewed
Apr 15, 2019
Collaborator
|
looks good, just have one question. At some point we may want to use a file/CSV writer so that we don't buffer everything in memory, but for now should be fine. SonarCloud is complaining about duplicate lines, but it's unclear to me as to why. |
pjlittle
approved these changes
Apr 15, 2019
wbreza
suggested changes
Apr 15, 2019
Contributor
wbreza
left a comment
There was a problem hiding this comment.
Can you please re-target to develop branch. I don't believe there should be anything related to active learning here.
Contributor
Author
|
@wbreza unfortunately I started this from the Active Learning branch so if I re-target to develop it will contains all the commits from that branch too. I think we have to first approve the AL PR. If this is urgent of course we could just copy the changes manually on a new branch but is this really so urgent ? |
cb71bae to
d6db509
Compare
3b8d7fe to
976bf0b
Compare
wbreza
approved these changes
Apr 26, 2019
elizabethhalper
pushed a commit
to riagarg/VoTT
that referenced
this pull request
Aug 20, 2019
author Wallace Breza <wallace@breza.me> 1556573964 -0700 committer Elizabeth Halper <elhalper@microsoft.com> 1566326008 -0700 parent e4ee4cd author Wallace Breza <wallace@breza.me> 1556573964 -0700 committer Elizabeth Halper <elhalper@microsoft.com> 1566326007 -0700 parent e4ee4cd author Wallace Breza <wallace@breza.me> 1556573964 -0700 committer Elizabeth Halper <elhalper@microsoft.com> 1566326004 -0700 parent e4ee4cd author Wallace Breza <wallace@breza.me> 1556573964 -0700 committer Elizabeth Halper <elhalper@microsoft.com> 1566325986 -0700 parent e4ee4cd author Wallace Breza <wallace@breza.me> 1556573964 -0700 committer Elizabeth Halper <elhalper@microsoft.com> 1566325973 -0700 Release 2.1.0 (microsoft#790) Updates package version and changelog for 2.1.0 release changed line refactor: Remove editor footer Dummy commit to kick off build again doc: Add bug & feature templates (microsoft#780) Adds bug and feature github templates Create CODE_OF_CONDUCT.md (microsoft#779) Adds code of conduct docs: updates to readme and changelog (microsoft#781) Minor updates and corrections to the main readme and changelog. fix: Fix display of tag color picker (microsoft#782) Resolves issue of tag color picker not being shown on alt-click or color-click + edit button. Also adds several tests for increased test coverage of tagInput.tsx feat: Add CSV Exporter (microsoft#757) Adds CSV export provider fix: change method for alloc string to buffer (microsoft#777) String.length is not appropriate for calculating buffer size when non-alphabet letter is included in content. Change the method Buffer.alloc to Buffer.from as directed by the nodejs document. fix: Updates backwards compat & fixes cntk export image bug (microsoft#789) Fixes an issue where the images exported out of a video file were missing file extension for video projects. Release 2.1.0 (microsoft#790) Updates package version and changelog for 2.1.0 release changed line rebase upstream dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CSV export provider to VoTT utilizing
json2csvnpm package