Linux: use stat to get filemode#800
Merged
jrbriggs merged 1 commit intomicrosoft:features/linuxprototypefrom Feb 20, 2019
Merged
Linux: use stat to get filemode#800jrbriggs merged 1 commit intomicrosoft:features/linuxprototypefrom
jrbriggs merged 1 commit intomicrosoft:features/linuxprototypefrom
Conversation
jrbriggs
suggested changes
Feb 18, 2019
MirrorProvider/MirrorProvider.Linux/LinuxFileSystemVirtualizer.cs
Outdated
Show resolved
Hide resolved
| using System.IO; | ||
| using System.Runtime.InteropServices; | ||
| using System.Text; | ||
| using Mono.Unix.Native; |
Member
There was a problem hiding this comment.
@wilbaker Can you comment on how we're doing platform native calls? Should we investigate if we should be using this library in the mac platform?
Contributor
Author
There was a problem hiding this comment.
fwiw, I tried a simple [DllImport("libc")] to get at the stat family of functions, but it didn't go down very well. I guess this is why Mono.Posix.NETStandard exists!
MirrorProvider/MirrorProvider.Linux/LinuxFileSystemVirtualizer.cs
Outdated
Show resolved
Hide resolved
e3cb0e6 to
2c3523a
Compare
Contributor
Author
|
Style nits attended to! |
Contributor
|
Looks great, thanks @kivikakk! |
jrbriggs
approved these changes
Feb 20, 2019
kivikakk
pushed a commit
to github/VFSForGit
that referenced
this pull request
Feb 21, 2019
Closed
kivikakk
pushed a commit
to github/VFSForGit
that referenced
this pull request
Mar 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create placeholders with the correct permissions. It's "just" the mirror provider, but it was bugging me enough that I wanted to fix it.
/cc @chrisd8088 fyi