Make delete docs more verbose.#1689
Merged
kyle-rader merged 2 commits intomicrosoft:masterfrom Aug 12, 2020
Merged
Conversation
derrickstolee
approved these changes
Aug 11, 2020
Contributor
derrickstolee
left a comment
There was a problem hiding this comment.
Thanks for this! Definitely an improvement and I only have a slight reorg comment.
derrickstolee
approved these changes
Aug 11, 2020
Contributor
Author
|
@derrickstolee seems one of the CI was cancelled for a timeout maybe? Or the agent machine was restarting? I don't think I have perms to request it re-run but feel free to force merge this if you are comfortable, otherwise, somehow re-queue the CI? |
Contributor
|
/azp run PR - Windows - Functional Tests (Sparse Mode) |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential issues
Added an explicit step for removing and added warning not to try deleting before un-mounting.