RepoRegistry: ignore non-existent repos#1652
Merged
derrickstolee merged 1 commit intomicrosoft:masterfrom Apr 14, 2020
Merged
Conversation
jrbriggs
approved these changes
Apr 13, 2020
The 'gvfs mount' command will send a message over the named pipe to deactivate a repo. This marks it with "IsActive = false" so we don't try to mount it at service startup. However, a repo can be deleted and then there is no way to send this message again. Instead, ignore repositories where the enlistment root does not exist. Don't remove it from the registry, since there may be a subtle reason why it is not visible from the serivce (such as a removed USB drive). Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
735e60b to
0fa5121
Compare
Merged
derrickstolee
added a commit
that referenced
this pull request
Apr 15, 2020
Includes the following PRs: * #1642: Update Git to v2.26.0 * #1647: Fix commit-graph expiration * #1652: RepoRegistry: ignore non-existent repos * #1653: Update Git to include v2.26.1 The update to include Git v2.26.0 comes with a new default backend for `git rebase`. By switching from the `apply` backend to the `merge` backend, some rebase situations that would previously fail will now succeed automatically. This comes with a slight performance drawback, but it is the direction that the Git community has decided to go. Please see [the Git documentation](https://git-scm.com/docs/git-rebase#_behavioral_differences) for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'gvfs mount' command will send a message over the named pipe to
deactivate a repo. This marks it with "IsActive = false" so we don't
try to mount it at service startup. However, a repo can be deleted
and then there is no way to send this message again.
Instead, ignore repositories where the enlistment root does not
exist. Don't remove it from the registry, since there may be a
subtle reason why it is not visible from the service (such as a
removed USB drive).
Resolves #1651.