Remove all reference to looseObjectCount in LooseObjectStepTests#1198
Merged
derrickstolee merged 1 commit intomicrosoft:masterfrom May 24, 2019
Merged
Conversation
When making the tests more flexible, I missed one instance. To be sure I didn't miss any more, I removed all storage of the exact loose object count. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
wilbaker
approved these changes
May 24, 2019
derrickstolee
added a commit
that referenced
this pull request
May 29, 2019
…nmounting These tests have been super-flaky and frustrating. After weakening the tests, but still finding places where the loose object count is not deterministic, I thought it was worth starting over with the full list of exact-count assertions. To avoid loose objects being added or dropped from the counts in unexpected ways, now we unmount the repo before counting the objects. I ran the functional tests 20 times on this PR and only one failure, but it was in the `GVFS.FunctionalTests.Tests.EnlistmentPerFixture.GitReadAndGitLockTests.GitAliasNamedAfterKnownCommandAcquiresLock()` test, unrelated to this change. Replaces #1162, #1198, #1116. Fixes #1201.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When making the tests more flexible in #1162, I missed one instance. To
be sure I didn't miss any more, I removed all use of the
exact loose object count.