refactor ReadLink into MirrorProvider.POSIX#1177
Merged
chrisd8088 merged 4 commits intomicrosoft:features/linuxprototypefrom May 21, 2019
Merged
refactor ReadLink into MirrorProvider.POSIX#1177chrisd8088 merged 4 commits intomicrosoft:features/linuxprototypefrom
chrisd8088 merged 4 commits intomicrosoft:features/linuxprototypefrom
Conversation
Contributor
|
This looks great to me, @kivikakk ... thank you! |
derrickstolee
approved these changes
May 20, 2019
Contributor
derrickstolee
left a comment
There was a problem hiding this comment.
A small suggestion around a case that probably will never happen. But never say never, right?
I do like dropping code clones, though.
Contributor
Author
|
Thanks for the review! I've made changes accordingly. (edit: looks like CI failure is flakey -- |
Contributor
Contributor
|
@derrickstolee -- I've been rebasing from master relatively often of late, but good to know there's a fix for one of the flaky CI tests; I'll pull that in soon. |
chrisd8088
added a commit
that referenced
this pull request
May 21, 2019
refactor ReadLink into MirrorProvider.POSIX Refactor our uses of libc's readlink(2) in the MirrorProvider for Mac and Linux into a common POSIX base, and also handle an unterminated buffer condition (and possible read past the end of the buffer) in the existing code by returning ENAMETOOLONG in this case.
chrisd8088
added a commit
that referenced
this pull request
May 21, 2019
refactor ReadLink into MirrorProvider.POSIX Refactor our uses of libc's readlink(2) in the MirrorProvider for Mac and Linux into a common POSIX base, and also handle an unterminated buffer condition (and possible read past the end of the buffer) in the existing code by returning ENAMETOOLONG in this case.
kivikakk
pushed a commit
to github/VFSForGit
that referenced
this pull request
May 24, 2019
refactor ReadLink into MirrorProvider.POSIX Refactor our uses of libc's readlink(2) in the MirrorProvider for Mac and Linux into a common POSIX base, and also handle an unterminated buffer condition (and possible read past the end of the buffer) in the existing code by returning ENAMETOOLONG in this case.
chrisd8088
added a commit
that referenced
this pull request
May 24, 2019
refactor ReadLink into MirrorProvider.POSIX Refactor our uses of libc's readlink(2) in the MirrorProvider for Mac and Linux into a common POSIX base, and also handle an unterminated buffer condition (and possible read past the end of the buffer) in the existing code by returning ENAMETOOLONG in this case.
chrisd8088
added a commit
that referenced
this pull request
Jul 20, 2019
refactor ReadLink into MirrorProvider.POSIX Refactor our uses of libc's readlink(2) in the MirrorProvider for Mac and Linux into a common POSIX base, and also handle an unterminated buffer condition (and possible read past the end of the buffer) in the existing code by returning ENAMETOOLONG in this case.
chrisd8088
added a commit
that referenced
this pull request
Jul 26, 2019
refactor ReadLink into MirrorProvider.POSIX Refactor our uses of libc's readlink(2) in the MirrorProvider for Mac and Linux into a common POSIX base, and also handle an unterminated buffer condition (and possible read past the end of the buffer) in the existing code by returning ENAMETOOLONG in this case.
chrisd8088
added a commit
that referenced
this pull request
Jul 28, 2019
refactor ReadLink into MirrorProvider.POSIX Refactor our uses of libc's readlink(2) in the MirrorProvider for Mac and Linux into a common POSIX base, and also handle an unterminated buffer condition (and possible read past the end of the buffer) in the existing code by returning ENAMETOOLONG in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor our uses of libc's
readlinkin the MirrorProvider for Mac and Linux.From @chrisd8088's suggestion at github#21 (comment).
/cc @derrickstolee @wilbaker