• On Linux should we also be excluding Categories.MacOnly?
• Could you incorporate these new exclusions in this if/else block just below?

if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
{
    excludeCategories.Add(Categories.MacTODO.FailsOnBuildAgent);
    excludeCategories.Add(Categories.MacTODO.NeedsNewFolderCreateNotification);
    excludeCategories.Add(Categories.MacTODO.NeedsGVFSConfig);
    excludeCategories.Add(Categories.MacTODO.NeedsDehydrate);
    excludeCategories.Add(Categories.MacTODO.NeedsServiceVerb);
    excludeCategories.Add(Categories.MacTODO.NeedsStatusCache);
    excludeCategories.Add(Categories.MacTODO.NeedsCorruptObjectFix);
    excludeCategories.Add(Categories.MacTODO.TestNeedsToLockFile);
    excludeCategories.Add(Categories.WindowsOnly);
}
else
{
    excludeCategories.Add(Categories.MacOnly);
}

• We already exclude MacOnly because of that same following block, which adds MacOnly to the exclusion list if the platform is not OSPlatform.OSX.
• I'm unsure on what you're asking with the second question here. Incorporate what new exclusions where?

• I'm unsure on what you're asking with the second question here. Incorporate what new exclusions where?

(To be clear, not trying to be obtuse! Just not parsing the question well.)

My reading of @wilbaker's suggestion here is that because many of these functional tests have not yet been ported to the Mac (and are therefore Windows-only not by design, but only because of lack of time), we will want to, for now, also exclude these on Linux. I'll make that change shortly!

I actually think I'm going to leave this as-is for now, because we haven't yet run the functional tests on Linux (see github#16) and so we may find that we need a different, likely larger, set of LinuxTODO tests. Until we investigate, it's a little hard to know which ones from the MacTODO category will really be POSIX-TODO and apply to Linux as well, and which are Mac-specific.

But as I'm 100% certain we'll be revisiting these tests and categoroes very soon, I think I'll go ahead and merge with this as it stands, as a placeholder (projecting filesystem pun intended! :-)

@kivikakk @chrisd8088 apologies for the confusion.

The idea in the second point was to combine the new if/else with the existing one below so that it would look something like:

if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
{
    excludeCategories.Add(... stuff excluded on Mac ...);
}
else if (RuntimeInformation.IsOSPlatform(Linux))
{
    excludeCategories.Add(... stuff excluded on Linux ...);
}
else
{
   excludeCategories.Add(... stuff excluded on Windows ...);
}

It can get tricky to keep track of what we're excluding or including, and it might be easier to keep track if we set them all in one spot.

To clarify, when I wrote excludeCategories.Add(... stuff excluded on <Platform> ...); I meant call excludeCategories.Add as many times as needed in each block to exclude what should be excluded on each platform

Ah, makes perfect sense. I'll do a PR for this -- thanks!

The good news is I was able to build your branch on Mac with Scripts/Mac/BuildGVFSForMac.sh. The bad news is that something is configured in a way that VS for Mac doesn't like, but that can get sorted out before this is merged to master.

Hm, can you describe it at all? I just tried a reasonably fresh build with VS for Mac of this tree and everything worked OK.

I trashed BuildOutput, packages, Publish, ran enough of BuildGVFSForMac.sh to generate the constants and assembly version files, then built the solution. Everything looks fine.

I will note that I encounter issues regularly if I try to build with VS and then build script (or vice versa) without cleaning everything in between — VS gets confused, red-underlines everything, says System is undefined, etc. etc. Just to see if I could trigger it in this case, after building with VS per above, I ran the full BuildGVFSForMac.sh, and then again in VS, and this one time it actually works.

(Well, actually, I get the incompatible SDK error thing on two projects, but that's not what I'm talking about and is already known!)

Hi, these are the errors I'm seeing:

Error: NuGet packages need to be restored before building. NuGet MSBuild targets are missing and are needed for building. The NuGet MSBuild targets are generated when the NuGet packages are restored. (GVFS.Common)

Error: NuGet packages need to be restored before building. NuGet MSBuild targets are missing and are needed for building. The NuGet MSBuild targets are generated when the NuGet packages are restored. (GVFS.Hooks.Mac)

Error: NuGet packages need to be restored before building. NuGet MSBuild targets are missing and are needed for building. The NuGet MSBuild targets are generated when the NuGet packages are restored. (GVFS.Tests)

I tried deleting BuildOutput, packages, and Publish but it didn't help.

Trying to make my steps reproducible:

• Start with VS closed.
• Deleted BuildOutput, packages, Publish. The clone is at ~/microsoft/VFSForGit/src, and the VFSForGit directory is empty except for the clone at src.
• Performed git clean -fdx in the clone.
• Opened GVFS.sln in Visual Studio for Mac (Community, 8.0.4 build 0).
• It automatically restored packages when opening the solution. (I'll omit the entire Package Console log, but the last line reads Packages successfully restored.)
• Tried to build the solution. Failed because I have Debug.Windows selected and a bunch of "This project type is not supported by Visual Studio Community 2019 for Mac." messages appeared.
• Switched to Debug.Mac. Failed because GVFSConstants.GitVersion.cs is not found.
• Made these changes to BuildGVFSForMac.sh and ran the script to create the two generated .cs files.
• Built the solution again.

• ========== Build: 16 succeeded, 0 failed, 2 up-to-date, 7 skipped ==========
  
  Build successful.
  

It's possible the git clean step was necessary? I'm not sure.

Ahh thanks, I did forget to run git clean, let me give that a try.