Allow unescaped paragraph and line separators in string literal#53869
Merged
jakebailey merged 4 commits intomicrosoft:mainfrom Sep 15, 2023
Conversation
…in string literal
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Contributor
Author
|
@microsoft-github-policy-service agree |
Member
|
I'm trying to get a grasp of this and here's what esbuild does. So, I think this is equivalent? |
jakebailey
reviewed
Apr 26, 2023
Member
jakebailey
left a comment
There was a problem hiding this comment.
Should tests/cases/compiler/sourceMap-LineBreaks.ts have changed? My impression is that it includes these characters, but, nothing happens?
…ph and line separators in string literal
jakebailey
approved these changes
Apr 27, 2023
snovader
pushed a commit
to EG-A-S/TypeScript
that referenced
this pull request
Sep 23, 2023
…osoft#53869) Co-authored-by: Liviu Gheorghe <liviu.gheorghe@ivfuture.uk> Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53519