Fix subtype reduction involving type variables with union constraints by ahejlsberg · Pull Request #53351 · microsoft/TypeScript

ahejlsberg · 2023-03-19T15:11:17Z

ahejlsberg · 2023-03-19T15:11:51Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-03-19T15:11:55Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at f6c466a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-19T15:11:55Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at f6c466a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-19T15:11:55Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at f6c466a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-19T15:11:55Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at f6c466a. You can monitor the build here.

typescript-bot · 2023-03-19T15:11:55Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at f6c466a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-19T15:23:57Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/53351/merge:

Everything looks good!

typescript-bot · 2023-03-19T15:27:01Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53351

_Metric	_main	₅₃₃₅₁	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{360,896k (± 0.01%)}	_{360,917k (± 0.01%)}	_~	_360,887k	_360,939k	_{p=0.199 n=6}
_{Parse Time}	_{3.52s (± 0.69%)}	_{3.53s (± 0.68%)}	_~	_3.51s	_3.57s	_{p=0.871 n=6}
_{Bind Time}	_{1.18s (± 0.69%)}	_{1.18s (± 0.54%)}	_~	_1.17s	_1.19s	_{p=0.432 n=6}
_{Check Time}	_{9.46s (± 0.52%)}	_{9.45s (± 0.31%)}	_~	_9.41s	_9.48s	_{p=0.871 n=6}
_{Emit Time}	_{7.93s (± 0.68%)}	_{7.91s (± 0.56%)}	_~	_7.88s	_8.00s	_{p=0.625 n=6}
_{Total Time}	_{22.10s (± 0.38%)}	_{22.08s (± 0.26%)}	_~	_22.00s	_22.16s	_{p=0.810 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,531k (± 0.04%)}	_{193,133k (± 0.70%)}	_~	_192,555k	_195,908k	_{p=0.471 n=6}
_{Parse Time}	_{1.57s (± 1.64%)}	_{1.57s (± 1.45%)}	_~	_1.53s	_1.59s	_{p=0.623 n=6}
_{Bind Time}	_{0.82s (± 0.77%)}	_{0.82s (± 0.00%)}	_~	_0.82s	_0.82s	_{p=1.000 n=6}
_{Check Time}	_{10.08s (± 0.62%)}	_{10.07s (± 0.46%)}	_~	_10.01s	_10.15s	_{p=0.575 n=6}
_{Emit Time}	_{2.99s (± 0.63%)}	_{2.98s (± 0.78%)}	_~	_2.95s	_3.02s	_{p=0.684 n=6}
_{Total Time}	_{15.47s (± 0.30%)}	_{15.44s (± 0.28%)}	_~	_15.38s	_15.49s	_{p=0.469 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,434k (± 0.01%)}	_{345,421k (± 0.00%)}	_~	_345,408k	_345,428k	_{p=0.106 n=6}
_{Parse Time}	_{2.72s (± 0.36%)}	_{2.72s (± 0.44%)}	_~	_2.71s	_2.74s	_{p=0.867 n=6}
_{Bind Time}	_{1.09s (± 0.50%)}	_{1.08s (± 0.59%)}	_~	_1.07s	_1.09s	_{p=0.201 n=6}
_{Check Time}	_{7.66s (± 0.32%)}	_{7.67s (± 0.31%)}	_~	_7.64s	_7.70s	_{p=0.625 n=6}
_{Emit Time}	_{4.42s (± 0.57%)}	_{4.42s (± 0.39%)}	_~	_4.40s	_4.44s	_{p=1.000 n=6}
_{Total Time}	_{15.89s (± 0.19%)}	_{15.89s (± 0.12%)}	_~	_15.86s	_15.91s	_{p=0.871 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,792k (± 0.01%)}	_{299,807k (± 0.01%)}	_~	_299,754k	_299,852k	_{p=0.377 n=6}
_{Parse Time}	_{2.17s (± 0.48%)}	_{2.17s (± 0.75%)}	_~	_2.15s	_2.19s	_{p=0.369 n=6}
_{Bind Time}	_{1.24s (± 0.88%)}	_{1.24s (± 1.10%)}	_~	_1.22s	_1.25s	_{p=0.798 n=6}
_{Check Time}	_{7.17s (± 0.57%)}	_{7.17s (± 0.39%)}	_~	_7.12s	_7.20s	_{p=0.936 n=6}
_{Emit Time}	_{4.31s (± 0.70%)}	_{4.35s (± 0.45%)}	_{+0.04s (+ 0.97%)}	_4.32s	_4.37s	_{p=0.036 n=6}
_{Total Time}	_{14.88s (± 0.33%)}	_{14.92s (± 0.18%)}	_~	_14.89s	_14.96s	_{p=0.106 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{477,460k (± 0.02%)}	_{477,477k (± 0.02%)}	_~	_477,355k	_477,588k	_{p=0.810 n=6}
_{Parse Time}	_{3.21s (± 0.36%)}	_{3.22s (± 0.64%)}	_~	_3.19s	_3.24s	_{p=0.281 n=6}
_{Bind Time}	_{0.95s (± 0.54%)}	_{0.96s (± 0.54%)}	_~	_0.95s	_0.96s	_{p=0.311 n=6}
_{Check Time}	_{17.96s (± 0.49%)}	_{17.95s (± 0.27%)}	_~	_17.89s	_18.01s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.12s (± 0.45%)}	_{22.13s (± 0.20%)}	_~	_22.09s	_22.21s	_{p=0.810 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,802k (± 0.02%)}	_{550,703k (± 0.01%)}	_~	_550,613k	_550,821k	_{p=0.093 n=6}
_{Parse Time}	_{3.94s (± 0.35%)}	_{3.94s (± 0.21%)}	_~	_3.93s	_3.95s	_{p=0.195 n=6}
_{Bind Time}	_{1.80s (± 0.30%)}	_{1.79s (± 0.74%)}	_~	_1.77s	_1.80s	_{p=0.490 n=6}
_{Check Time}	_{3.03s (± 0.39%)}	_{3.02s (± 0.74%)}	_~	_2.99s	_3.05s	_{p=0.418 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.86s (± 0.27%)}	_{8.85s (± 0.38%)}	_~	_8.82s	_8.90s	_{p=0.518 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₅₁	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-03-19T17:12:58Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-03-19T17:24:15Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/53351/merge:

Everything looks good!

ahejlsberg · 2023-03-21T14:54:37Z

Tests and performance are unchanged. This one is good to go.

jakebailey

Do we need to backport this to 5.0?

ahejlsberg · 2023-03-21T19:51:26Z

Do we need to backport this to 5.0?

I could go either way on that. The underlying issue has been present for years, but the combination of that and an unrelated change in 5.0 caused a regression.

jakebailey · 2023-03-21T19:53:08Z

I'll trigger it anyway, and we can discuss it at a meeting.

@typescript-bot cherry-pick this to release-5.0

typescript-bot · 2023-03-21T19:53:11Z

Heya @jakebailey, I've started to run the task to cherry-pick this into release-5.0 on this PR at f6c466a. You can monitor the build here.

typescript-bot · 2023-03-21T19:58:06Z

Hey @jakebailey, I've opened #53422 for you.

Component commits: 3811515 Fix subtype reduction involving type variables with union constraints f6c466a Add tests

…e-5.0 (#53422) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

…to release-5.0 (microsoft#53422) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

ahejlsberg added 2 commits March 19, 2023 08:05

Fix subtype reduction involving type variables with union constraints

3811515

Add tests

f6c466a

typescript-bot assigned ahejlsberg Mar 19, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 19, 2023

ahejlsberg requested review from DanielRosenwasser and RyanCavanaugh March 21, 2023 14:55

jakebailey approved these changes Mar 21, 2023

View reviewed changes

ahejlsberg merged commit bace689 into main Mar 21, 2023

ahejlsberg deleted the fix53311 branch March 21, 2023 19:52

typescript-bot mentioned this pull request Mar 21, 2023

🤖 Pick PR #53351 (Fix subtype reduction involving typ...) into release-5.0 #53422

Merged

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 21, 2023

Cherry-pick PR microsoft#53351 into release-5.0

35a87bd

Component commits: 3811515 Fix subtype reduction involving type variables with union constraints f6c466a Add tests

DanielRosenwasser pushed a commit that referenced this pull request Mar 28, 2023

🤖 Pick PR #53351 (Fix subtype reduction involving typ...) into releas…

7e093f0

…e-5.0 (#53422) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

drivron pushed a commit to scenari/typescript that referenced this pull request Sep 14, 2023

🤖 Pick PR microsoft#53351 (Fix subtype reduction involving typ...) in…

c3d59b8

…to release-5.0 (microsoft#53422) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

ahejlsberg commented Mar 19, 2023

Uh oh!

ahejlsberg commented Mar 19, 2023

Uh oh!

typescript-bot commented Mar 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 19, 2023

Uh oh!

typescript-bot commented Mar 19, 2023

Uh oh!

typescript-bot commented Mar 19, 2023

Uh oh!

typescript-bot commented Mar 19, 2023

Uh oh!

ahejlsberg commented Mar 21, 2023

Uh oh!

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

ahejlsberg commented Mar 21, 2023

Uh oh!

jakebailey commented Mar 21, 2023

Uh oh!

typescript-bot commented Mar 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 19, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading