Merged
Conversation
Member
Author
|
@typescript-bot perf test this |
Collaborator
|
Heya @amcasey, I've started to run the perf test suite on this PR at 7091edc. You can monitor the build here. Update: The results are in! |
Collaborator
|
@amcasey Here they are:Comparison Report - main..44710
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
Author
|
I'm extremely skeptical that this could have reduced check time since, AFAIK, none of our benchmarks are built in watch mode and the checker does not use |
Member
Author
|
@typescript-bot perf test this |
Collaborator
|
Heya @amcasey, I've started to run the perf test suite on this PR at d9ae52c. You can monitor the build here. Update: The results are in! |
Collaborator
|
@amcasey Here they are:Comparison Report - main..44710
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| const toCanonical = createGetCanonicalFileName(useCaseSensitiveFileNames); | ||
| for (const basePath of patterns.basePaths) { | ||
| visitDirectory(basePath, combinePaths(currentDirectory, basePath), depth); | ||
| if (directoryExists(basePath)) { |
Contributor
There was a problem hiding this comment.
@amcasey I wonder if this check is causing a behavior change in the material-ui benchmark and changing the number of .d.ts files that get loaded or similar.
Member
There was a problem hiding this comment.
Comparing --extendedDiagnostics might be a good first step to figuring out whether there really is an observable behavior change, if you haven't already done that @amcasey
Member
Author
There was a problem hiding this comment.
Sorry, we'd been discussing this offline and I forgot to update the issue. The perf suite was using the wrong baseline. I'll kick off a clean run now, but local testing showed no change in the check time of material-ui.
Member
Author
There was a problem hiding this comment.
I guess I should also say that I don't believe it will cause a behavioral change because visitDirectory would just see an empty list of fs entries for the non-existent directory and stop.
The latest perf run shows no change, as expected. 😄
There was a problem hiding this comment.
@amcasey Hi! I don't know if it the right place to ask a question but I found this thread relative to the problem (I'm sorry if it's not). Should directoryExists be called with an absolute path like directoryExists(combinePaths(currentDirectory, basePath))?
I came across the undocumented breaking change in 4.4-beta that causes (for example) ts.sys.readDirectory("", [".ts",".tsx",".d.ts"],["node_modules","dist"],["**/*"]) to return an empty array. Before 4.4-beta it has been returning the correct array of files. So I wonder if it is a bug or desired behaviour.
Thank you in advance.
Member
Author
|
@typescript-bot perf test this |
Collaborator
|
Heya @amcasey, I've started to run the perf test suite on this PR at d9ae52c. You can monitor the build here. Update: The results are in! |
Collaborator
|
@amcasey Here they are:Comparison Report - main..44710
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
andrewbranch
approved these changes
Jun 28, 2021
DanielRosenwasser
added a commit
that referenced
this pull request
Sep 21, 2021
This reverts commit c0d5c29.
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 27, 2021
As pointed out by @gretzkiy, the `directoryExists` call added to `matchFiles` in microsoft#44710 should have been passing the absolute path (since the current directory might not match `currentDirectory`).
andrewbranch
added a commit
that referenced
this pull request
Oct 21, 2021
* Pass absolute path to directoryExists As pointed out by @gretzkiy, the `directoryExists` call added to `matchFiles` in #44710 should have been passing the absolute path (since the current directory might not match `currentDirectory`). * Add test, simplify/clarify/fix matchFiles and friends Co-authored-by: Andrew Branch <andrew@wheream.io>
andrewbranch
added a commit
to andrewbranch/TypeScript
that referenced
this pull request
Nov 11, 2021
This reverts commit c0d5c29.
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Nov 11, 2021
Component commits: 931b504 Revert "Fix RWC missing file detection (microsoft#46673)" This reverts commit 4a065f5. afef282 Revert "Pass absolute path to directoryExists (microsoft#46086)" This reverts commit 55b4928. f1a20b3 Revert "Reduce exceptions (microsoft#44710)" This reverts commit c0d5c29. 56842cd Add back system watcher limit
andrewbranch
added a commit
that referenced
this pull request
Nov 11, 2021
Component commits: 931b504 Revert "Fix RWC missing file detection (#46673)" This reverts commit 4a065f5. afef282 Revert "Pass absolute path to directoryExists (#46086)" This reverts commit 55b4928. f1a20b3 Revert "Reduce exceptions (#44710)" This reverts commit c0d5c29. 56842cd Add back system watcher limit Co-authored-by: Andrew Branch <andrew@wheream.io>
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
* Pass absolute path to directoryExists As pointed out by @gretzkiy, the `directoryExists` call added to `matchFiles` in microsoft#44710 should have been passing the absolute path (since the current directory might not match `currentDirectory`). * Add test, simplify/clarify/fix matchFiles and friends Co-authored-by: Andrew Branch <andrew@wheream.io>
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
…46787) * Revert "Fix RWC missing file detection (microsoft#46673)" This reverts commit 4a065f5. * Revert "Pass absolute path to directoryExists (microsoft#46086)" This reverts commit 55b4928. * Revert "Reduce exceptions (microsoft#44710)" This reverts commit c0d5c29. * Add back system watcher limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up a couple of exceptions that were being thrown repeatedly during initial project load of a large project on Linux:
matchFilesshouldn't callvisitDirectoryonbasePathsthat don't exist (throwing fromrealpathandreaddir)After this change, "All Exceptions" causes the debugger to stop exactly twice: when
typescript-etwis found to be absent and the first time the file watcher limit is hit.This change is purely to make it easier to enable "All Exceptions" when debugging TypeScript - not for correctness or (significant) perf improvements.