Handle browserify-ignored module result for etw logger#33225
Merged
weswigham merged 1 commit intomicrosoft:masterfrom Sep 4, 2019
Merged
Handle browserify-ignored module result for etw logger#33225weswigham merged 1 commit intomicrosoft:masterfrom
weswigham merged 1 commit intomicrosoft:masterfrom
Conversation
Member
Author
|
cc @DanielRosenwasser we'll need to port this patch to 3.6 to fix browserifying TS 3.6 |
Member
|
Tell the bot, that's what they're here for! 😁 |
Member
Author
|
Hey, I just wanted you to know before we cut a release @DanielRosenwasser @typescript-bot cherry-pick this into release-3.6 |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Sep 3, 2019
Component commits: 541e96e Handle browserify-ignored module result for etw logger
Collaborator
|
Hey @weswigham, I've opened #33226 for you. |
Member
Author
|
@DanielRosenwasser wanna actually 👍 this? |
sheetalkamat
approved these changes
Sep 4, 2019
Contributor
|
@weswigham while at it, mind also adding I could open an issue though, if you want that issue addressed separately. |
Member
Author
|
Feel free to open - I didn't realize we required that outside the test harness. |
weswigham
pushed a commit
that referenced
this pull request
Sep 4, 2019
Component commits: 541e96e Handle browserify-ignored module result for etw logger
timsuchanek
pushed a commit
to timsuchanek/TypeScript
that referenced
this pull request
Sep 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33224