Skip to content

Fix visitLexicalEnvironment to properly merge hoisted declarations#33219

Merged
rbuckton merged 1 commit intomasterfrom
fix33217
Sep 3, 2019
Merged

Fix visitLexicalEnvironment to properly merge hoisted declarations#33219
rbuckton merged 1 commit intomasterfrom
fix33217

Conversation

@rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Sep 3, 2019

Fixes #33217

@rbuckton rbuckton requested a review from weswigham September 3, 2019 21:04
@rbuckton
Copy link
Contributor Author

rbuckton commented Sep 3, 2019

I'll need to either cherry-pick and open this against release-3.6 as well.

@rbuckton
Copy link
Contributor Author

rbuckton commented Sep 3, 2019

@typescript-bot cherry-pick this into release-3.6

@typescript-bot
Copy link
Collaborator

Hey @rbuckton, I've opened #33222 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Sep 3, 2019
Component commits:
ffc82db Fix visitLexicalEnvironment to properly merge hoisted declarations
@rbuckton rbuckton mentioned this pull request Sep 3, 2019
7 tasks
rbuckton pushed a commit that referenced this pull request Sep 3, 2019
Component commits:
ffc82db Fix visitLexicalEnvironment to properly merge hoisted declarations
@rbuckton rbuckton merged commit 3b96729 into master Sep 3, 2019
@rbuckton rbuckton deleted the fix33217 branch September 3, 2019 22:29
timsuchanek pushed a commit to timsuchanek/TypeScript that referenced this pull request Sep 11, 2019
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect emit for hoisted variables and "use strict" at the top of a file.

3 participants