Skip to content

Add tr1 testsuite#652

Merged
cbezault merged 5 commits intomicrosoft:masterfrom
cbezault:enable-tr1
Mar 30, 2020
Merged

Add tr1 testsuite#652
cbezault merged 5 commits intomicrosoft:masterfrom
cbezault:enable-tr1

Conversation

@cbezault
Copy link
Contributor

@cbezault cbezault commented Mar 29, 2020

Description

Enable tr1 tests.

@cbezault cbezault added the test Related to test code label Mar 29, 2020
@cbezault cbezault requested a review from a team as a code owner March 29, 2020 01:05
StephanTLavavej
StephanTLavavej approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I double-checked that no tr1 README changes are necessary in response to this.

Note that #647 edits the top-level README to say "tr1 and portions of std are still a work in progress." If that's merged after this PR, it should be adjusted accordingly.

@cbezault
Copy link
Contributor Author

cbezault commented Mar 29, 2020 •
edited
Loading

I believe that _tempnam in the cwchar1 test is returning the same file name to multiple processes which causes a race between test processes. _tempanm's documentation states that the directory provided to it is ignored if TMP is a valid directory.

@cbezault
Copy link
Contributor Author

cbezault commented Mar 29, 2020

I'd like to merge this PR without a green checkmark. I've opened #655 to deal with the single test failure.

@CaseyCarter
Copy link
Contributor

CaseyCarter commented Mar 29, 2020 •
edited
Loading

I'd like to merge this PR without a green checkmark. I've opened #655 to deal with the single test failure.

Why not simply merge that change into this PR? Or merge this PR after #655? I'd rather not have the repo ever be in a state in which tests fail, even a transient state, because it will inhibit our ability to bisect and perform code archaeology.

@cbezault
Copy link
Contributor Author

cbezault commented Mar 29, 2020

Re-running takes so long 😢. But you're right. I'll wait until after #655 .

@cbezault cbezault mentioned this pull request Mar 30, 2020
Closed
@CaseyCarter
Copy link
Contributor

CaseyCarter commented Mar 30, 2020

Re-running takes so long 😢

We have been so spoiled by our ten-minute CI ;)

@cbezault cbezault merged commit 811c8c1 into microsoft:master Mar 30, 2020
fengjixuchui added a commit to fengjixuchui/STL that referenced this pull request Mar 30, 2020
@fengjixuchui
Merge pull request #49 from microsoft/master
adf53f7 
Add tr1 testsuite (microsoft#652)
@cbezault cbezault linked an issue Apr 9, 2020 that may be closed by this pull request
GitHub: Onboard tr1 tests #144
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal Awaiting requested review from BillyONeal

@StephanTLavavej StephanTLavavej Awaiting requested review from StephanTLavavej

1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cbezault cbezault

Labels

test Related to test code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitHub: Onboard tr1 tests

4 participants

@cbezault @CaseyCarter @BillyONeal @StephanTLavavej