Skip to content

Add futures.unique_future/wait.pass.cpp to the skip lists#641

Merged
cbezault merged 1 commit intomicrosoft:masterfrom
cbezault:skip_thread_test
Mar 27, 2020
Merged

Add futures.unique_future/wait.pass.cpp to the skip lists#641
cbezault merged 1 commit intomicrosoft:masterfrom
cbezault:skip_thread_test

Conversation

@cbezault
Copy link
Contributor

Description

The timing assumptions on this test are unreliable and cause sporadic failures. Add it to the skip list.

Checklist

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

@cbezault cbezault added the test Related to test code label Mar 26, 2020
@cbezault cbezault requested a review from a team as a code owner March 26, 2020 16:45
@cbezault cbezault changed the title <tests>: Add futures.unique_future/wait.pass.cpp to the skip lists Add futures.unique_future/wait.pass.cpp to the skip lists Mar 26, 2020
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cbezault
Copy link
Contributor Author

Looks like we need to increase the timeout for building the support tools

@BillyONeal
Copy link
Member

That was a full twice as long as it normally takes, I wonder if AV tools got us there.

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cbezault cbezault merged commit 5f7933c into microsoft:master Mar 27, 2020
cbezault added a commit to cbezault/STL that referenced this pull request Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Related to test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants