Remove _NODISCARD_FRIEND workaround#4782
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Jul 5, 2024
Merged
Conversation
StephanTLavavej
approved these changes
Jul 3, 2024
Member
|
Thanks for doing the archaeology to figure out exactly when this workaround became unnecessary! 😻 This change is super safe because we began requiring CUDA 11.6.0 with #2791 in VS 2022 17.4, two years ago. |
_NODISCARD_FRIEND workaround
miscco
approved these changes
Jul 4, 2024
Contributor
miscco
left a comment
There was a problem hiding this comment.
This mirrors what we are doing in cccl
miscco
approved these changes
Jul 4, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for cleaning up this old workaround! 🧹 🪄 😻 |
This was referenced Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4104
I believe the workaround is not needed since CUDA 11.3.0: https://gcc.godbolt.org/z/bPh1av5f9
I used this version Cuda 12.4.0: https://developer.download.nvidia.com/compute/cuda/12.4.0/network_installers/cuda_12.4.0_windows_network.exe