-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Closed
Labels
enhancementSomething can be improvedSomething can be improvedfixedSomething works now, yay!Something works now, yay!
Description
- Shortly before 2018-05: The bug EDGcpfe/19388, corresponding to VSO-568006 "REPORTED: Attributes are not accepted on friend definitions inside class templates", was fixed upstream by EDG.
- 2018-05: The EDG fix was picked up by IntelliSense.
- 2019-08: CUDA 10.1 Update 2 was released (it did not contain the EDG fix, to the best of my knowledge).
- 2021-12:
<random>: Implement LWG-3519 #2208 introduced_NODISCARD_FRIENDto centralize our workaround. - 2022-01: CUDA 11.6.0 was released.
- 2022-06: Toolset update: VS 2022 17.3 Preview 2, CUDA 11.6.0 #2791 increased our required version from CUDA 10.1 Update 2 to CUDA 11.6.0.
- 2024-03: Toolset update: VS 2022 17.10 Preview 2, WinSDK 22621, CUDA 12.4.0 #4475 increased our required version to CUDA 12.4.0.
From this timeline, I suspect, but haven't confirmed, that we no longer need this workaround. If someone has time to check, that would be great. (I don't think our minimal CUDA test coverage is detailed enough to have confidence that simply removing the workaround and looking for test failures would be sufficient validation.)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementSomething can be improvedSomething can be improvedfixedSomething works now, yay!Something works now, yay!