Implement LWG-3561 Issue with internal counter in discard_block_engine#4066
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Oct 4, 2023
Merged
Implement LWG-3561 Issue with internal counter in discard_block_engine#4066StephanTLavavej merged 2 commits intomicrosoft:mainfrom
discard_block_engine#4066StephanTLavavej merged 2 commits intomicrosoft:mainfrom
Conversation
Also correct the types of static data members `block_size` and `used_block`.
088b367 to
eb2ee46
Compare
StephanTLavavej
approved these changes
Oct 3, 2023
Member
|
Thanks! After thinking about this carefully, I believe that this strategy is safe - it changes layout only for template arguments that were totally broken before. (Also this is highly unlikely to have occurred in practice.) And as I replied to the comment that @MattStephanson raised, the I believe that I understand these changes well enough that only one maintainer approval is needed. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing this penultimate LWG issue! 🎉 😻 📉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By changing the base type of
discard_block_enginewhen_Pxis too large fordiscard_blockto work. The changes will break ABI for somediscard_block_enginespecializations that didn't previously work.I haven't come up with a portable way for testing, because what I had tried took a long while to run.
Also correct the types of static data members
block_sizeandused_block.Fixes #2250.