-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Description
LWG-3561 Issue with internal counter in discard_block_engine
Discussion from the meta-issue #2236:
- @MattStephanson
LWG-3561: This would involving changing
discard_block's internal_Nxcounter and template arguments frominttosize_t, which I think would be an ABI break. I think the most we could do now is add a// TRANSITION, ABIcomment, and maybe astatic_assertfordiscard_block_enginethat its parameters must be <=INT_MAX. - @CaseyCarter
I think we could greatly improve
discard_block_engineby divorcing it completely from the TR1-eradiscard_block. We could even make it toleratep > INT_MAX, but I agree thatr > INT_MAXis not supportable without breaking ABI. - @timsong-cpp
Couldn't you change the type of
_Nxonly ifr > INT_MAX?
Edit: looks like MSVC doesn't check narrowing fromsize_ttointin the NTTP, hmm...is it an ABI break if the existing thing compiles but totally doesn't work?
Metadata
Metadata
Assignees
Labels
Type
Projects
Status