STL.natvis: Simplify visualization for mutex/recursive_mutex#3848
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Aug 3, 2023
Merged
STL.natvis: Simplify visualization for mutex/recursive_mutex#3848StephanTLavavej merged 2 commits intomicrosoft:mainfrom
STL.natvis: Simplify visualization for mutex/recursive_mutex#3848StephanTLavavej merged 2 commits intomicrosoft:mainfrom
Conversation
strega-nil-ms
approved these changes
Jul 5, 2023
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
Thanks so much! (it also works on MSVC/ARM64)
StephanTLavavej
approved these changes
Jul 5, 2023
Member
|
This removes the ability for the new IDE to visualize old-compiled |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Jul 21, 2023
strega-nil-ms
approved these changes
Aug 1, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for improving these visualizers! 👁️ 👀 👁️🗨️ |
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Aug 30, 2023
…utex` (microsoft#3848)" This reverts commit 9b4a05c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
locking_thread_idandownership_levelscan be represented by named members now, so I believe we can simplify its visualization.I've verified that the outputs are unchanged for
std::recursive_mutexwith every combination of MSVC/Clang, x64/x86, and Debug/Release.