Skip to content

Fix ranges::is_permutation's helper lambdas#3113

Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom
JMazurkiewicz:fix_is_permutation
Sep 22, 2022
Merged

Fix ranges::is_permutation's helper lambdas#3113
StephanTLavavej merged 2 commits intomicrosoft:mainfrom
JMazurkiewicz:fix_is_permutation

Conversation

@JMazurkiewicz
Copy link
Contributor

Fixes #2888.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner September 19, 2022 14:09
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StephanTLavavej StephanTLavavej added bug Something isn't working ranges C++20/23 ranges labels Sep 20, 2022
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except for an extraneous semicolon, which I'll cleanup.

@StephanTLavavej
Copy link
Member

✅ No modules impact here (I am double-checking in-flight PRs to make sure we don't miss any needed exports).

@StephanTLavavej StephanTLavavej self-assigned this Sep 22, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej changed the title Fix ranges::is_permutations's helper lambdas Fix ranges::is_permutation's helper lambdas Sep 22, 2022
@StephanTLavavej StephanTLavavej merged commit b79bbbc into microsoft:main Sep 22, 2022
@StephanTLavavej
Copy link
Member

compiler for Thanks 😹 errors! ✅ these fixing 🎉

@JMazurkiewicz JMazurkiewicz deleted the fix_is_permutation branch September 22, 2022 21:50
CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request Oct 6, 2022
Co-authored-by: Casey Carter <cartec69@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ranges C++20/23 ranges

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<algorithm>: ranges::is_permutation's helper lambda does not specify return type

4 participants