Implement LWG-3712: chunk_view and slide_view should not be default_initializable#2943
Merged
StephanTLavavej merged 6 commits intomicrosoft:mainfrom Jul 28, 2022
Merged
Conversation
26 tasks
StephanTLavavej
approved these changes
Jul 27, 2022
Comment on lines
+38
to
+40
| // Validate non-default-initializability | ||
| STATIC_ASSERT(!is_default_constructible_v<R>); | ||
| STATIC_ASSERT(!default_initializable<R>); |
Member
There was a problem hiding this comment.
No change requested: test_one() is called for both input-only and forward ranges, so this covers the LWG issue's modifications to both the primary template and the specialization for forward ranges.
CaseyCarter
approved these changes
Jul 27, 2022
StephanTLavavej
approved these changes
Jul 27, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing so many LWG issue resolutions and improving conformance! 😻 😻 😻 😻 😻 😻 😻 😻 |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
…ult_initializable` (microsoft#2943) Co-authored-by: Casey Carter <Casey@Carter.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #2872.