Implement LWG-3724: decay-copy should be constrained#2903
Merged
StephanTLavavej merged 5 commits intomicrosoft:mainfrom Jul 28, 2022
Merged
Implement LWG-3724: decay-copy should be constrained#2903StephanTLavavej merged 5 commits intomicrosoft:mainfrom
decay-copy should be constrained#2903StephanTLavavej merged 5 commits intomicrosoft:mainfrom
Conversation
26 tasks
CaseyCarter
suggested changes
Jul 25, 2022
| unsigned int size_ = 0u; | ||
|
|
||
| weird_string_view() = default; | ||
| explicit weird_string_view(const weird_string_view&) = default; |
Contributor
There was a problem hiding this comment.
copy_constructible requires implicit copy construction via convertible_to<const T&, T>, so this is a move-only view. (No change requested.)
CaseyCarter
approved these changes
Jul 26, 2022
StephanTLavavej
approved these changes
Jul 26, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing so many LWG issue resolutions and improving conformance! 😻 😻 😻 😻 |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #2872.
Only one case in the
operator()of_All_fn(the type ofviews::all) needs additional constraints. MSVC STL has already constrained it withconstructible_from, but sometimesconstructible_fromseems still insufficient.I'm not sure whether the difference between
constructible_fromandconvertible_tois observable outside of IFNDR, or whetherweird_string_viewin the test file actually modelsview.