Use conditional explicit unconditionally#2796
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Jun 20, 2022
Merged
Conversation
AlexGuteniev
approved these changes
Jun 16, 2022
celonymire
approved these changes
Jun 16, 2022
Contributor
celonymire
left a comment
There was a problem hiding this comment.
The diff ratio is satisfying
Member
Author
|
I'm speculatively mirroring this to the MSVC-internal repo. Further changes can be pushed, but please notify me. |
CaseyCarter
approved these changes
Jun 19, 2022
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
For posterity: I verified with a quick grep that all mentions of _HAS_CONDITIONAL_EXPLICIT are gone.
miscco
approved these changes
Jun 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1301. This is possible now that toolset update #2791 requires CUDA 11.6.0.
Thanks to @AlexGuteniev for verifying that CUDA 11.6.0 supports this, and to @cpplearner for verifying the Intel compiler's behavior. 😻
This doesn't affect our primary compilers (MSVC, Clang, EDG IntelliSense), as we were already using the Future Technology codepath for them. It's a massive maintainability improvement, and also a throughput improvement for CUDA.
In
<yvals_core.h>, I opted to keep the#if !_HAS_CXX20order, despite our usual preference to avoid negated tests. This is consistent with#if !_HAS_CXX17immediately above, and in this case I think the "if we don't have C++20, then suppress the warning" phrasing is easier to understand than the reverse.