Toolset update: VS 2022 17.3 Preview 1#2714
Merged
StephanTLavavej merged 9 commits intomicrosoft:mainfrom May 12, 2022
Merged
Conversation
Should be paired with MSVC-internal changes to: src/vctools/crt/crt_build.settings.targets
We probably need to modify src/vctools/crt/crt-common.settings.targets to set Win32WinNt and NtddiVersion.
strega-nil-ms
approved these changes
May 11, 2022
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
This LGTM, but I don't feel comfortable enough with the codebase yet to be a final reviewer.
Member
Author
|
Mirrored to internal MSVC-PR-398667 with passing tests. (I can easily push changes to both for code review feedback.) |
CaseyCarter
approved these changes
May 12, 2022
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
Verified there are no remaining mentions of /Za and winsdk, and no files with winsdk in their names.
CaseyCarter
approved these changes
May 12, 2022
CaseyCarter
pushed a commit
to CaseyCarter/STL
that referenced
this pull request
May 13, 2022
This was referenced May 13, 2022
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stl/CMakeLists.txt, we don't need to includecrt/src/concrtanymore.<concrtinternal.h>etc.src/vctools/crt/crt_build.settings.targets.<Windows.h>from headers) allows us to remove a couple of long-standing workarounds.filesystem.cpp, we can directly useFILE_DISPOSITION_INFO_EXnow.static_assertthat thesestructs are layout-compatible, and that the constants have identical values.CMakeLists.txt, we need to increaseNTDDI_VERSIONin order to get the declaration ofFileDispositionInfoEx. Instead of increasing it to the exact value we need, I am going further and increasing it to the maximum supported value right now,NTDDI_WIN10_CO, so that we can access other declarations if necessary (see the comment above)._WIN32_WINNT(due to an apparent mistake in the WinSDK headers, theFILE_DISPOSITION_FLAG_DELETEetc. macros are effectively unguarded), but I am increasing it to its maximum value of Win10 for consistency.src/vctools/crt/crt-common.settings.targets, settingWin32WinNtandNtddiVersion./Zatest coverage. (No product changes.)/Zaconfigurations from the remaining matrices (we never combined them with unique options so they can simply be dropped) and removes some test workarounds./Za)./Zahas always been problematically buggy, but it also used to be the only way to request extra conformance from MSVC. Now,/permissive-and/Zc:preprocessorhave morally superseded/Za, and/Zais officially discouraged in the documentation. We also have excellent conformance coverage from Clang in its strict mode and EDG, so it has been aeons since/Zafound anything in the STL that needed to be changed. Removing this test coverage doesn't block users from using/Zawith the STL, and we'll continue to fix any reported conformance issues in the library, but we won't spend effort on working around/Zabugs in the product and test code._declspecin the ancientDev09_056375_locale_cleanup/testdll.cpp./Za, the compiler emitted errors in the WinSDK headers followed by complaining about this single-underscore extension; we should fix it even though we're dropping/Zacoverage).