Implement LWG-3598 `system_category().default_error_condition(0)` by fsb4000 · Pull Request #2560 · microsoft/STL

fsb4000 · 2022-02-11T13:38:37Z

Fixes #2552

Should I add a reminder for moving the fix to syserror.cpp when we will be able to modify the file?

cond.message() == "Операция успешно завершена." on my PC.

it's definitely something else on your PC so I decided to test with != the fallback.

StephanTLavavej · 2022-02-11T13:41:04Z

Should I add a reminder for moving the fix to syserror.cpp when we will be able to modify the file?

I think that a TRANSITION comment, a followup issue, or both, would be appropriate.

fsb4000 · 2022-02-11T14:16:19Z

I looked at

STL/stl/src/syserror.cpp

Lines 113 to 194 in bbd5dba

    
               constexpr _Sys_errtab_t _Sys_errtab[] = { 
        
                   // table of Posix code/name pairs 
        
                   {errc::address_family_not_supported, "address family not supported"}, 
        
                   {errc::address_in_use, "address in use"}, 
        
                   {errc::address_not_available, "address not available"}, 
        
                   {errc::already_connected, "already connected"}, 
        
                   {errc::argument_list_too_long, "argument list too long"}, 
        
                   {errc::argument_out_of_domain, "argument out of domain"}, 
        
                   {errc::bad_address, "bad address"}, 
        
                   {errc::bad_file_descriptor, "bad file descriptor"}, 
        
                   {errc::bad_message, "bad message"}, 
        
                   {errc::broken_pipe, "broken pipe"}, 
        
                   {errc::connection_aborted, "connection aborted"}, 
        
                   {errc::connection_already_in_progress, "connection already in progress"}, 
        
                   {errc::connection_refused, "connection refused"}, 
        
                   {errc::connection_reset, "connection reset"}, 
        
                   {errc::cross_device_link, "cross device link"}, 
        
                   {errc::destination_address_required, "destination address required"}, 
        
                   {errc::device_or_resource_busy, "device or resource busy"}, 
        
                   {errc::directory_not_empty, "directory not empty"}, 
        
                   {errc::executable_format_error, "executable format error"}, 
        
                   {errc::file_exists, "file exists"}, 
        
                   {errc::file_too_large, "file too large"}, 
        
                   {errc::filename_too_long, "filename too long"}, 
        
                   {errc::function_not_supported, "function not supported"}, 
        
                   {errc::host_unreachable, "host unreachable"}, 
        
                   {errc::identifier_removed, "identifier removed"}, 
        
                   {errc::illegal_byte_sequence, "illegal byte sequence"}, 
        
                   {errc::inappropriate_io_control_operation, "inappropriate io control operation"}, 
        
                   {errc::interrupted, "interrupted"}, 
        
                   {errc::invalid_argument, "invalid argument"}, 
        
                   {errc::invalid_seek, "invalid seek"}, 
        
                   {errc::io_error, "io error"}, 
        
                   {errc::is_a_directory, "is a directory"}, 
        
                   {errc::message_size, "message size"}, 
        
                   {errc::network_down, "network down"}, 
        
                   {errc::network_reset, "network reset"}, 
        
                   {errc::network_unreachable, "network unreachable"}, 
        
                   {errc::no_buffer_space, "no buffer space"}, 
        
                   {errc::no_child_process, "no child process"}, 
        
                   {errc::no_link, "no link"}, 
        
                   {errc::no_lock_available, "no lock available"}, 
        
                   {errc::no_message_available, "no message available"}, 
        
                   {errc::no_message, "no message"}, 
        
                   {errc::no_protocol_option, "no protocol option"}, 
        
                   {errc::no_space_on_device, "no space on device"}, 
        
                   {errc::no_stream_resources, "no stream resources"}, 
        
                   {errc::no_such_device_or_address, "no such device or address"}, 
        
                   {errc::no_such_device, "no such device"}, 
        
                   {errc::no_such_file_or_directory, "no such file or directory"}, 
        
                   {errc::no_such_process, "no such process"}, 
        
                   {errc::not_a_directory, "not a directory"}, 
        
                   {errc::not_a_socket, "not a socket"}, 
        
                   {errc::not_a_stream, "not a stream"}, 
        
                   {errc::not_connected, "not connected"}, 
        
                   {errc::not_enough_memory, "not enough memory"}, 
        
                   {errc::not_supported, "not supported"}, 
        
                   {errc::operation_canceled, "operation canceled"}, 
        
                   {errc::operation_in_progress, "operation in progress"}, 
        
                   {errc::operation_not_permitted, "operation not permitted"}, 
        
                   {errc::operation_not_supported, "operation not supported"}, 
        
                   {errc::operation_would_block, "operation would block"}, 
        
                   {errc::owner_dead, "owner dead"}, 
        
                   {errc::permission_denied, "permission denied"}, 
        
                   {errc::protocol_error, "protocol error"}, 
        
                   {errc::protocol_not_supported, "protocol not supported"}, 
        
                   {errc::read_only_file_system, "read only file system"}, 
        
                   {errc::resource_deadlock_would_occur, "resource deadlock would occur"}, 
        
                   {errc::resource_unavailable_try_again, "resource unavailable try again"}, 
        
                   {errc::result_out_of_range, "result out of range"}, 
        
                   {errc::state_not_recoverable, "state not recoverable"}, 
        
                   {errc::stream_timeout, "stream timeout"}, 
        
                   {errc::text_file_busy, "text file busy"}, 
        
                   {errc::timed_out, "timed out"}, 
        
                   {errc::too_many_files_open_in_system, "too many files open in system"}, 
        
                   {errc::too_many_files_open, "too many files open"}, 
        
                   {errc::too_many_links, "too many links"}, 
        
                   {errc::too_many_symbolic_link_levels, "too many symbolic link levels"}, 
        
                   {errc::value_too_large, "value too large"}, 
        
                   {errc::wrong_protocol_type, "wrong protocol type"}, 
        
               }; 
        
           } // unnamed namespace

and it seems generic error messages don't depend on locale. (while system error messages do)

stl/inc/system_error

tests/std/tests/Dev11_0493504_error_category_lifetime/test.cpp

StephanTLavavej · 2022-02-17T09:48:19Z

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. (I'll handle verifying that this works with the recent LLVM update.)

StephanTLavavej · 2022-02-18T02:01:53Z

Success! Thanks for implementing this LWG issue 😻 🎉 🚀

implement LWG-3598

cc05f47

fsb4000 requested a review from a team as a code owner February 11, 2022 13:38

StephanTLavavej added the LWG Library Working Group issue label Feb 11, 2022

fsb4000 added 3 commits February 11, 2022 20:58

now error_code() == error_condition()

e8f303b

TRANSITION reminder

9a38476

_Sys_errtab doesn't depend on locale

bc2e901

update test

9642d5d

CaseyCarter suggested changes Feb 11, 2022

View reviewed changes

stl/inc/system_error Show resolved Hide resolved

early-return

01c6330

fsb4000 requested a review from CaseyCarter February 12, 2022 02:13

CaseyCarter approved these changes Feb 12, 2022

View reviewed changes

StephanTLavavej approved these changes Feb 15, 2022

View reviewed changes

tests/std/tests/Dev11_0493504_error_category_lifetime/test.cpp Show resolved Hide resolved

StephanTLavavej self-assigned this Feb 17, 2022

StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request Feb 17, 2022

microsoftGH-2560

a7b0509

StephanTLavavej merged commit 202e42a into microsoft:main Feb 18, 2022

fsb4000 deleted the fix2552 branch February 18, 2022 03:31

StephanTLavavej mentioned this pull request May 27, 2022

syserror.cpp: update _Syserror_map #2742

Merged

invertego mentioned this pull request Jun 4, 2022

<future>: promise default constructs the value type #2488

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement LWG-3598 `system_category().default_error_condition(0)`#2560

Implement LWG-3598 `system_category().default_error_condition(0)`#2560
StephanTLavavej merged 6 commits intomicrosoft:mainfrom
fsb4000:fix2552

fsb4000 commented Feb 11, 2022 •

edited

Loading

Uh oh!

StephanTLavavej commented Feb 11, 2022

Uh oh!

fsb4000 commented Feb 11, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

StephanTLavavej commented Feb 17, 2022

Uh oh!

StephanTLavavej commented Feb 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

fsb4000 commented Feb 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StephanTLavavej commented Feb 11, 2022

Uh oh!

fsb4000 commented Feb 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StephanTLavavej commented Feb 17, 2022

Uh oh!

StephanTLavavej commented Feb 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fsb4000 commented Feb 11, 2022 •

edited

Loading

fsb4000 commented Feb 11, 2022 •

edited

Loading