Merged
Conversation
39 tasks
CaseyCarter
approved these changes
Oct 11, 2021
Contributor
|
FYI, I pushed a tiny formatting fix. |
StephanTLavavej
approved these changes
Oct 14, 2021
Member
|
Thanks, I really appreciate your archaeological investigations here! 😻 |
Member
|
I'm mirroring this to an MSVC-internal PR; please notify me if any further changes are pushed. |
Member
|
I've pushed a merge with |
Member
|
Thanks again! 😻 🚀 🎉 |
SiliconA-Z
pushed a commit
to SiliconA-Z/STL
that referenced
this pull request
Nov 4, 2021
Co-authored-by: Casey Carter <Casey@Carter.net> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove comments that cite:
operator<=>(optional<T>, U)basic_istream_viewneeds to initializevalue_)join_view::iterator::iterator_categoryand::iterator_conceptlie (appears once with the number, and once as "LWG issue unnumbered as of 2021-03-16")noexcept-specifiers forbasic_syncbufbasic_string_viewnot trivially move constructiblemove_iterator operator+()has incorrect constraintsSeveral drive-by changes:
join_view::_Iteratoris updated with the issue number (which is LWG-3569 "join_viewfails to support ranges of ranges with non-default_initializableiterators")swapforbasic_syncbuf"<xstring>is removed. I believe that the comment refers to the bug that was fixed in cplusplus/draft@c3c40a3.