Implement P1147R1 "Printing volatile Pointers"#2262
Merged
StephanTLavavej merged 12 commits intomicrosoft:mainfrom Oct 20, 2021
Merged
Implement P1147R1 "Printing volatile Pointers"#2262StephanTLavavej merged 12 commits intomicrosoft:mainfrom
StephanTLavavej merged 12 commits intomicrosoft:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
AlexGuteniev
reviewed
Oct 6, 2021
This comment has been minimized.
This comment has been minimized.
This reverts commit 5b75b76.
AlexGuteniev
approved these changes
Oct 7, 2021
CaseyCarter
suggested changes
Oct 13, 2021
CaseyCarter
approved these changes
Oct 14, 2021
AlexGuteniev
approved these changes
Oct 14, 2021
Member
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks! This looks good, I'll push changes for incredibly minor nitpicks.
StephanTLavavej
approved these changes
Oct 15, 2021
Member
|
I'm mirroring this to an MSVC-internal PR; please notify me if any further changes are pushed. |
Member
|
I've pushed a merge with |
Member
|
Thanks for implementing this highly volatile feature! 💥 😹 ✔️ |
SiliconA-Z
pushed a commit
to SiliconA-Z/STL
that referenced
this pull request
Nov 4, 2021
Co-authored-by: Casey Carter <Casey@Carter.net> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2246