Use iterator concept in vector's range constructor#1794
Use iterator concept in vector's range constructor#1794StephanTLavavej merged 14 commits intomicrosoft:mainfrom
Conversation
|
Welcome to container hell, please take a seat |
|
You might also have a look at |
|
Could someone explain to me why |
StephanTLavavej
left a comment
There was a problem hiding this comment.
After merging #1771, there are non-trivial merge conflicts in <vector>.
|
Also counts towards #189 |
I believe this is because a Forward Iterator can be read multiple times (the idea is that they're like Apologies for the year-long delay in answering this question 😹 |
|
@StephanTLavavej It seems that it might change with P2520. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Thanks, this looks great! I found only minor issues while video reviewing, so I went ahead and validated and pushed changes. |
CaseyCarter
left a comment
There was a problem hiding this comment.
This is an interesting extension, since it's almost exactly the change WG21-P2408 will have us making to the non-permuting std algorithms for C++23. I think we're going to be seeing a lot of similar relaxations for "old" standard library code in C++26 as WG21 is getting our brains wrapped around where and how we can make these integrations without breaking programs in the wild.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for improving the performance of the STL's most important data structure! 😻 🚀 🚀 |
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Fixes #1709.