-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Open
Labels
blockedSomething is preventing work on thisSomething is preventing work on thisenhancementSomething can be improvedSomething can be improved
Description
After microsoft/GSL#821 "gsl_byte should inspect __cpp_lib_byte in addition to _HAS_STD_BYTE" is fixed, _HAS_STD_BYTE should no longer be needed for detection.
After the Windows SDK's unqualified mentions of byte (referring to their own ::byte) are fixed, _HAS_STD_BYTE should no longer be needed for control.
Then we can finally remove:
Lines 475 to 477 in 447f879
| #ifndef _HAS_STD_BYTE | |
| #define _HAS_STD_BYTE _HAS_CXX17 // inspected by GSL, do not remove | |
| #endif // _HAS_STD_BYTE |
Also, I created microsoft/GSL#1145 so that GSL will no longer inspect _HAS_STD_BYTE at all.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
blockedSomething is preventing work on thisSomething is preventing work on thisenhancementSomething can be improvedSomething can be improved