Inspect only __cpp_lib_byte, drop _HAS_STD_BYTE#1145
Merged
d-winsor merged 1 commit intomicrosoft:mainfrom Feb 26, 2024
StephanTLavavej:byte
Merged
Inspect only __cpp_lib_byte, drop _HAS_STD_BYTE#1145d-winsor merged 1 commit intomicrosoft:mainfrom StephanTLavavej:byte
__cpp_lib_byte, drop _HAS_STD_BYTE#1145d-winsor merged 1 commit intomicrosoft:mainfrom
StephanTLavavej:byte
Conversation
d-winsor
approved these changes
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long-awaited followup to #822 which addressed #821.
GSL 4.0.0, released 2 years ago, dropped support for VS 2017. Only VS 2019 and VS 2022 are supported. Therefore, GSL can now always use the Standard feature-test macro
__cpp_lib_byteto sense whether MSVC's STL providesstd::byte. It should no longer inspect the non-Standard macro_HAS_STD_BYTE(which is our "control macro").