Avoid utils depending on pytest#4692
Merged
jenshnielsen merged 1 commit intomicrosoft:masterfrom Oct 5, 2022
Merged
Conversation
We do this by temp copying compare_dictionaries back to this module but deprecated
Codecov Report
@@ Coverage Diff @@
## master #4692 +/- ##
==========================================
- Coverage 68.24% 68.18% -0.06%
==========================================
Files 339 339
Lines 31979 32006 +27
==========================================
Hits 21823 21823
- Misses 10156 10183 +27 |
astafan8
approved these changes
Oct 5, 2022
jenshnielsen
added a commit
that referenced
this pull request
Oct 5, 2022
Avoid utils depending on pytest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal function compare_dictionaries has moved to the testing module but we import it here for backwards compatibility.
That triggers an unwanted import of pytest so to fix this we opt for coping it deprecated here rather than importing it.