[Enterprise; Policy] Add policy for CursorWrap to ADMX#45028
[Enterprise; Policy] Add policy for CursorWrap to ADMX#45028vanzue merged 3 commits intomicrosoft:mainfrom
Conversation
|
@niels9001 |
There was a problem hiding this comment.
Pull request overview
Adds the missing Group Policy definition for the CursorWrap utility so it appears in ADMX/Intune administrative templates.
Changes:
- Bumped ADMX/ADML revision to
1.19and updated min required revision for resources. - Added
SUPPORTED_POWERTOYS_0_97_0supported-on entry. - Introduced the
ConfigureEnabledUtilityCursorWrappolicy definition and its localized display string.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/gpo/assets/en-US/PowerToys.adml |
Updates revision and adds localized strings for v0.97.0 support and the CursorWrap enabled-state policy display name. |
src/gpo/assets/PowerToys.admx |
Updates revision/minRequiredRevision, adds v0.97.0 supported-on definition, and adds the CursorWrap enabled-state policy entry. |
| <string id="ConfigureEnabledUtilityKeyboardManager">Keyboard Manager: Configure enabled state</string> | ||
| <string id="ConfigureEnabledUtilityFindMyMouse">Find My Mouse: Configure enabled state</string> | ||
| <string id="ConfigureEnabledUtilityMouseHighlighter">Mouse Highlighter: Configure enabled state</string> | ||
| <string id="ConfigureEnabledUtilityCursorWrap">CursorWrap: Configure enabled state</string> |
There was a problem hiding this comment.
The display string for this policy uses "CursorWrap" without a space. Elsewhere in the codebase the feature is referred to as "Cursor Wrap" (e.g., cmdpal Toggle Cursor Wrap strings), and using the spaced name makes the policy more readable and easier to find via search. Consider changing this to "Cursor Wrap: Configure enabled state" while keeping the string id/policy name as-is.
| <string id="ConfigureEnabledUtilityCursorWrap">CursorWrap: Configure enabled state</string> | |
| <string id="ConfigureEnabledUtilityCursorWrap">Cursor Wrap: Configure enabled state</string> |
There was a problem hiding this comment.
@niels9001
I thought I have seen the spaced version somewhere. But I can't remember where. What is the correct name?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| <definition name="SUPPORTED_POWERTOYS_0_89_0" displayName="$(string.SUPPORTED_POWERTOYS_0_89_0)"/> | ||
| <definition name="SUPPORTED_POWERTOYS_0_90_0" displayName="$(string.SUPPORTED_POWERTOYS_0_90_0)"/> | ||
| <definition name="SUPPORTED_POWERTOYS_0_96_0" displayName="$(string.SUPPORTED_POWERTOYS_0_96_0)"/> | ||
| <definition name="SUPPORTED_POWERTOYS_0_97_0" displayName="$(string.SUPPORTED_POWERTOYS_0_97_0)"/> |
There was a problem hiding this comment.
Shall we mark the version as 0_97_1?
There was a problem hiding this comment.
I realize our code has already support the cursorwrap, so we are good to use 0.97 here?
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Added missing policy definition. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #44897 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [x] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [x] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [x] **Documentation updated:** See PR for issue #44484 <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Added missing policy definition. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #44897 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [x] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [x] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [x] **Documentation updated:** See PR for issue #44484 <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
Summary of the Pull Request
Added missing policy definition.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed