Skip to content

Conversation

@srinathsetty
Copy link
Collaborator

No description provided.

@srinathsetty srinathsetty merged commit 562fa71 into main May 13, 2022
@srinathsetty srinathsetty deleted the bn branch May 13, 2022 08:50
huitseeker added a commit to huitseeker/Nova that referenced this pull request Nov 3, 2023
…ommitment key size hint

- Converted `CommitmentKeyHint<G>` from a boxed dynamic trait object to a direct dynamic trait object in `r1cs/mod.rs`.
- Changed the `commitment_key` function to always require a commitment key floor, eliminating the need for default behavior when a floor function isn't provided.
- Updated the `r1cs_shape` function across various files to take in a `CommitmentKeyHint` instead of it being optional and introduce a closure as an argument.
- Relevant modifications and updates were made in the `r1cs_shape` and `commitment_key` function calls within the test functions for various modules.
- Ported use of commitment key hint to Supernova, closing microsoft#53.
- This PR puts Arecibo in line with microsoft#203
huitseeker added a commit to huitseeker/Nova that referenced this pull request Nov 6, 2023
…ommitment key size hint (microsoft#95)

* refactor: Refactor public parameters setup to remove optionality of commitment key size hint

- Converted `CommitmentKeyHint<G>` from a boxed dynamic trait object to a direct dynamic trait object in `r1cs/mod.rs`.
- Changed the `commitment_key` function to always require a commitment key floor, eliminating the need for default behavior when a floor function isn't provided.
- Updated the `r1cs_shape` function across various files to take in a `CommitmentKeyHint` instead of it being optional and introduce a closure as an argument.
- Relevant modifications and updates were made in the `r1cs_shape` and `commitment_key` function calls within the test functions for various modules.
- Ported use of commitment key hint to Supernova, closing microsoft#53.
- This PR puts Arecibo in line with microsoft#203

* doc: document Supernova Public Parameters

- Enhanced the `PublicParams` struct within `./src/supernova/mod.rs` with detailed comments

* feat: Refactor to use `default_commitment_key_hint` across codebase

- Introduced a new function `default_commitment_key_hint` in `nova_snark` package to provide a clearer default sizing hint for the commitment key,
- Replaced hard-coded zero values throughout the codebase with calls to `default_commitment_key_hint` function,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants